Petr Horáček has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan ......................................................................
Patch Set 2: Verified-1
(1 comment)
https://gerrit.ovirt.org/#/c/65231/2/tests/network/func_net_basic_test.py File tests/network/func_net_basic_test.py:
Line 38: class NetworkBasicTemplate(NetFuncTestCase): Line 39: __test__ = False Line 40: Line 41: @contextmanager Line 42: def _test_detach_used_nic_from_bridge(self): test always passes (even without the fix) on dummies, it fails when nic is system nic (eth1) Line 43: with dummy_device() as nic: Line 44: NETCREATE = { Line 45: NETWORK1_NAME: {'nic': nic, 'switch': self.switch}, Line 46: NETWORK2_NAME: {'nic': nic, 'vlan': VLAN2,