Alon Bar-Lev has posted comments on this change.
Change subject: Packaging: Fix help string and usage for --disable-libvirt-sanlock
......................................................................
Patch Set 4:
(2 comments)
....................................................
File configure.ac
Line 47
Line 48
Line 49
Line 50
Line 51
I do not follow... please be consistent... if you put default here you should put default
on disable bellow, the format should be the same.
....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 207: set_if_default "${lconf}" auth_unix_rw \"sasl\"
Line 208: set_if_default "${lconf}" host_uuid
"\"$(uuidgen)\""
Line 209: set_if_default "${lconf}" keepalive_interval -1
Line 210: set_if_default "${qconf}" dynamic_ownership 0
Line 211: if [ "${ENABLE_LIBVIRT_SELINUX}" != "yes" ]; then
as far as I can see this is a bug fix not fixing the strings especially if we add the
consistent handling of all enable/disable... but not that important.
Line 212: set_if_default "${qconf}" security_driver \"none\"
Line 213: fi
Line 214:
Line 215: if [ "${ssl}" = "true" ]; then
--
To view, visit
http://gerrit.ovirt.org/19005
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I935693a8b8e7c371c653853b9524c9a774bca6fd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes