Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Add initial FakeLVM tests and fix errors ......................................................................
tests: Add initial FakeLVM tests and fix errors
The FakeLVM class inside storagefakelib.py is becoming increasingly complex. In order to ensure that FakeLVM is providing correct LVM emulation we need to test its output against what a real LVM environment would present.
This first patch introduces the new test module and adds some tests for createVG and getVG. We test that the VG properties and attributes returned match a real LVM installation. After writing these tests I found and fixed several errors in the existing FakeLVM implementation.
Change-Id: I1650b98f25df1a22ba2a0920b093e78fc2fdee88 Signed-off-by: Adam Litke alitke@redhat.com Reviewed-on: https://gerrit.ovirt.org/47857 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer nsoffer@redhat.com --- M tests/Makefile.am M tests/storagefakelib.py A tests/storagefakelibTests.py 3 files changed, 158 insertions(+), 15 deletions(-)
Approvals: Adam Litke: Verified Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests