Dan Kenigsberg has posted comments on this change.
Change subject: build: Add an option to skip unit tests ......................................................................
Patch Set 1: I would prefer that you didn't submit this
adding documentation is a good idea 95% of the time, so please do. You can update http://www.ovirt.org/wiki/Features/Nose_tests or add a README, or a even a hint to `make check` saying something like:
"If you are short in time and do not care about code quality, avoid this step with NOSE_EXCLUDE=.*"
(I do not mind little jokes in Makefiles)
-- To view, visit http://gerrit.ovirt.org/3906 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0714099b3d388a4081896cb5b76fca613067e28f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com