Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: sync logging between two phases ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vds_bootstrap/vds_bootstrap_complete.py Line 41: Line 42: try: Line 43: import deployUtil Line 44: except: Line 45: message = "Error trying to deploy library." I am not sure this is such a bad idea. swallowing errors silently is a bad practice, worthy of a z-stream. Line 46: print ("<BSTRAP component='INIT' status='FAIL' message='%s'/>" % message) Line 47: logging.debug("<BSTRAP component='INIT' status='FAIL' message='%s'/>", message) Line 48: logging.error(message, exc_info=True) Line 49: exit(-1)
-- To view, visit http://gerrit.ovirt.org/7089 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iac3faeeaa9e85d92e1d8bcec6517745a665a3da8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server