Dan Kenigsberg has posted comments on this change.
Change subject: Add a flag to libvirtvm's status to report watchdog event ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 2224: return actionStrings[action] Line 2225: except IndexError: Line 2226: return "Received unknown watchdog action(%s)" % action Line 2227: Line 2228: self.watchdogEvent = {} Python allows adding object attributes outside __init__, but without strong reasons, I feel that it lead to run-time surprises.
Could there be more than one watchdog event per VM? Maybe an initially-empty list of events would be good enough. Line 2229: self.watchdogEvent["time"] = time.time() Line 2230: self.watchdogEvent["action"] = actionToString(action) Line 2231: self.log.debug("Watchdog event comes from guest %s. " Line 2232: "Action: %s", self.conf['vmName'],
-- To view, visit http://gerrit.ovirt.org/9429 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7aa676299c748d761e216469569156140a79af65 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server