Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix vdsm_hooks pep8. ......................................................................
Patch Set 1:
Output of gitpydiff:
antoni@nx01 ~/code/vdsm> gitpydiff checking vdsm_hooks/directlun/after_vm_destroy.py checking vdsm_hooks/directlun/before_vm_migrate_destination.py checking vdsm_hooks/directlun/before_vm_start.py checking vdsm_hooks/faqemu/before_vm_start.py checking vdsm_hooks/floppy/before_vm_migrate_source.py checking vdsm_hooks/floppy/before_vm_start.py checking vdsm_hooks/hostusb/after_vm_destroy.py checking vdsm_hooks/hostusb/before_vm_start.py checking vdsm_hooks/hugepages/after_vm_destroy.py checking vdsm_hooks/hugepages/before_vm_migrate_destination.py checking vdsm_hooks/hugepages/before_vm_start.py checking vdsm_hooks/isolatedprivatevlan/before_vm_start.py checking vdsm_hooks/nestedvt/before_vm_start.py checking vdsm_hooks/numa/before_vm_start.py checking vdsm_hooks/pincpu/before_vm_start.py checking vdsm_hooks/promisc/before_vm_destroy.py checking vdsm_hooks/qos/before_vm_start.py 2 difference(s) first file: vdsm_hooks/qos/before_vm_start.py second file: /tmp/pydiff/vdsm_hooks/qos/before_vm_start.py
((31, "\nQoS Hook\n========\nlibvirt domain xml:\n<interface>\n ...\n <bandwidth>\n <inbound average='1' peak='2' burst='5'/>\n <outbound average='0.5'/>\n </bandwidth>\n ...\n</interface>\n\nNote:\n for average, peak, and burst explanation look at:\n # man tc tbf\n\n'average' attribute is mandatory,\ninbound or outbound elements can be once but not mandatory\n\nsyntax:\n 00:11:22:33:44:55=in{'average':'1','peek':'2','burst':'5'}^out{'average':'1'}&11:11:11:11:11:11=...\n"), (30, "\nQoS Hook\n========\nlibvirt domain xml:\n<interface>\n ...\n <bandwidth>\n <inbound average='1' peak='2' burst='5'/>\n <outbound average='0.5'/>\n </bandwidth>\n ...\n</interface>\n\nNote:\n for average, peak, and burst explanation look at:\n # man tc tbf\n\n'average' attribute is mandatory,\ninbound or outbound elements can be once but not mandatory\n\nsyntax:\n 00:11:22:33:44:55=in{'average':'1','peek':'2','burst':'5'}^"))
(('31 +', None), (31, Discard(Const("out{'average':'1'}&11:11:11:11:11:11=..."))))
checking vdsm_hooks/smbios/before_vm_start.py checking vdsm_hooks/sriov/after_vm_destroy.py 1 difference(s) first file: vdsm_hooks/sriov/after_vm_destroy.py second file: /tmp/pydiff/vdsm_hooks/sriov/after_vm_destroy.py
((18, '!='), (19, 'is not'))
checking vdsm_hooks/vmdisk/before_vm_start.py antoni@nx01 ~/code/vdsm>
-- To view, visit http://gerrit.ovirt.org/10777 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ida004331709ac573db4ae6bf77da407830b31ac8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server