From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: cmdutils: add env to exec_cmd()'s args ......................................................................
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/79694/10/tests/common/cmdutils_test.py File tests/common/cmdutils_test.py:
Line 147: self.assertEqual(out, b'') Line 148: Line 149: def test_exec_cmd_with_env(self): Line 150: rc, out, err = cmdutils.exec_cmd( Line 151: ('sh', '-c', 'echo $XXX'), env={'XXX': 'hello'})
printenv XXX would be little nicer.
but more obscure - I did not know of it. Line 152: self.assertEqual(rc, 0)