Dan Kenigsberg has posted comments on this change.
Change subject: fix can't get ssl opt in vdsm sos plugin ......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/sos/vdsm.py.in Line 63: os.environ["LVM_SYSTEM_DIR"] = os.path.join(constants.P_VDSM_RUN, this usage of os.path.join is unrelated to this patch. please remove, as it confuses people to think that it has some functional effect.
note that this module is so very Un*x-oriented, that having os.path.join is not *really* important. if you want it very much, send another patch with it.
-- To view, visit http://gerrit.ovirt.org/4349 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Icbbc9a10202f191d0754bfae5c3f876b6c53a560 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com