Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 2: (2 inline comments)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 51: import socket Line 52: import tempfile Line 53: from time import strftime Line 54: Line 55: bootstrap_interface_version = 1 This is not constant, it is global.
It accepts the bootstrap interface version so script may behave as engine expects. This is our backward compatibility hint for now... until I rewrite a whole new process. Line 56: Line 57: # set logging before deployUtil is first used Line 58: try: Line 59: LOGDIR=os.environ["OVIRT_LOGDIR"]
Line 946: -f <firewall_rules_file> -- override firewall rules. Line 947: -V - don't install virtualization service Line 948: -g - install gluster service Line 949: obsolete options: Line 950: -r <rev_num> Done Line 951: """ Line 952: try: Line 953: global bootstrap_interface_version Line 954: rev_num = None
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server