Michael Burns has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 9: (1 inline comment)
.................................................... File vdsm/vdsm-restore-net-config Line 29: # this should NOT be used in ovirt-node, where configuration persistence is Line 30: # handled otherwise. Line 31: try: Line 32: if os.path.exists('/etc/rhev-hypervisor-release') or \ Line 33: not len(glob.glob('/etc/ovirt-node-*-release')) == 0: this will probably work, but why not use isOvirt from deployUtil.py (or relocate the function into a common place and use it from there? Line 34: return Line 35: except: Line 36: pass Line 37:
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server