From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net test: Cleanup colliding test ip rules
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/76781/7/tests/network/__init__.py
File tests/network/__init__.py:
Line 28: from . ip_rule_test import IPV4_ADDRESS1
Line 29:
Line 30:
Line 31: def teardown_package():
Line 32: if six.PY2:
pardon my ignorance, but why is this specific to PY2?
Line 33: _cleanup_stale_iprules()
Line 34:
Line 35:
Line 36: class StaleIPRulesError(Exception):
PS7, Line 54: Exception as e
brrr. but as I said, I would not fight over this.
--
To view, visit https://gerrit.ovirt.org/76781
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I461ad5697525cfaa2e3c6cfa66269692283903ce
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: build: add pylint to check target
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/76390
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a14a4d1a0f37397d1f5f89f33517ee87e95eb28
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: rename binding
......................................................................
Patch Set 14: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/72768
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45271691c3898678ff7d331d99ebb1d398a640af
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net test: Cleanup colliding test ip rules
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/76781/3/tests/network/ip_rule_test.py
File tests/network/ip_rule_test.py:
Line 35:
Line 36:
Line 37: @ValidateRunningAsRoot
Line 38: def setup_module():
Line 39: _cleanup_colliding_test_iprules()
I believe that Edy's idea, of running the cleanup on tearDown, and raising an error if the cleaup was needed is much nicer.
Line 40:
Line 41:
Line 42: @attr(type='integration')
Line 43: class TestIpRule(VdsmTestCase):
--
To view, visit https://gerrit.ovirt.org/76781
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I461ad5697525cfaa2e3c6cfa66269692283903ce
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net test: Cleanup colliding test ip rules
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/76781/3/tests/network/ip_rule_test.py
File tests/network/ip_rule_test.py:
Line 54
Line 55
Line 56
Line 57
Line 58
> Why the cleanup is assumed to succeed when same code failed and left the ho
this patch aims to fix a slave that was ruined by an aberrant test; not to fix a known-and-understood problem.
(that's what makes me uncomfortable in taking it)
--
To view, visit https://gerrit.ovirt.org/76781
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I461ad5697525cfaa2e3c6cfa66269692283903ce
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: rawhide: Add ovirt-imageio-commmon from Fedora 25
......................................................................
rawhide: Add ovirt-imageio-commmon from Fedora 25
We don't build ovirt-imageio yet for rawhide, so install the rpm for
Fedora 25 from ovirt-release-master repository.
Change-Id: I2c0b4272b79b52b6e29067ee1a1b4b37d7c0bf86
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M docker/Dockerfile.fedora.rawhide
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Nir Soffer: Verified; Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/76788
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c0b4272b79b52b6e29067ee1a1b4b37d7c0bf86
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: rawhide: Skip blivet tests on Fedora rawhide
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/76777/4/tests/gluster_cli_test.py
File tests/gluster_cli_test.py:
Line 1122: try:
Line 1123: from vdsm.gluster.storagedev import _parseDevices \
Line 1124: as parseStorageDevices
Line 1125: except (ImportError, ValueError) as e:
Line 1126: # On Fedora rawhide importing blivet fail with:
it is a bit of a shame to ignore an error on all platforms, just because a bug exists a rawhide.
Any sane idea to limit the test-skipping?
Line 1127: # ValueError: Namespace BlockDev not available for version 1.0
Line 1128: # See https://bugzilla.redhat.com/1450607
Line 1129: raise SkipTest('%s' % e)
Line 1130:
--
To view, visit https://gerrit.ovirt.org/76777
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I050475289756649d4ae58af08f405ffaef6f8d30
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: api: Handle calls without context
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/76752
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79c9fa859a71d538729130e5bc878dd47d2bb702
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: rawhide: Add Fedora rawhide image
......................................................................
rawhide: Add Fedora rawhide image
Testing with Fedora development image will help to find and fix
regression quickly.
ovirt-imageio-common is required, but it is not available yet for
rawhide. Remove it until it will be available, so we can find other
issues with this image.
Change-Id: Iaf2e5c6e4ddf981d086a1b8095bcf8ee51f0d074
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
A docker/Dockerfile.fedora.rawhide
1 file changed, 56 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76566
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf2e5c6e4ddf981d086a1b8095bcf8ee51f0d074
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>