Change in vdsm[master]: vm: use response.success() in setIoTune
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vm: use response.success() in setIoTune
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/75944
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e27a00586d767aaa0f3a43717f2272c238366c1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[ovirt-4.1]: spec: call systemd-tmpfiles --create post uninstall in upgra...
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: spec: call systemd-tmpfiles --create post uninstall in upgrade scenario
......................................................................
spec: call systemd-tmpfiles --create post uninstall in upgrade scenario
https://gerrit.ovirt.org/#/c/68662/ causes several folders in
/var/run/vdsm (payload, trackedInterfaces, v2v) to be missing in an
upgrade scenario from 4.1.0 and 4.1.1 to 4.2.
This patch calls systemd-tmpfiles in an upgrade scenario, re-creating
the folders.
This patch/fix isn't relevant to master/4.2 as the folders are created
in master/4.2 via systemd-tmpfiles
(https://gerrit.ovirt.org/#/c/69093/)
Label: ovirt-4.1-only
Bug-Id: https://bugzilla.redhat.com/1437448
Change-Id: I2da60e6e06b49f0d0bb2eb407d89dbefe8ded424
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Yaniv Bronhaim: Verified; Looks good to me, approved; Passed CI tests
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/76026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2da60e6e06b49f0d0bb2eb407d89dbefe8ded424
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
7 years, 1 month
Change in vdsm[ovirt-4.1]: spec: call systemd-tmpfiles --create post uninstall in upgra...
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: call systemd-tmpfiles --create post uninstall in upgrade scenario
......................................................................
Patch Set 5:
I changed the bugzilla component and signed verified for you. I didn't actually run it.
--
To view, visit https://gerrit.ovirt.org/76026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2da60e6e06b49f0d0bb2eb407d89dbefe8ded424
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[ovirt-4.1]: spec: call systemd-tmpfiles --create post uninstall in upgra...
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: call systemd-tmpfiles --create post uninstall in upgrade scenario
......................................................................
Patch Set 5: Code-Review+2 Continuous-Integration+1 Verified+1
--
To view, visit https://gerrit.ovirt.org/76026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2da60e6e06b49f0d0bb2eb407d89dbefe8ded424
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[ovirt-4.1]: spec: call systemd-tmpfiles --create post uninstall in upgra...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: spec: call systemd-tmpfiles --create post uninstall in upgrade scenario
......................................................................
Patch Set 5:
Unfortunately, only a human maintainer cares for
LABEL: ovirt-4.1 ONLY
no script has ever been made aware of it
--
To view, visit https://gerrit.ovirt.org/76026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2da60e6e06b49f0d0bb2eb407d89dbefe8ded424
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[ovirt-4.1]: spec: call systemd-tmpfiles --create post uninstall in upgra...
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: call systemd-tmpfiles --create post uninstall in upgrade scenario
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
add the label. don't we have VDSM bug for that "Check Product::#1437448::WARN, wrong product: ovirt-engine (-1)"
https://gerrit.ovirt.org/#/c/76026/4//COMMIT_MSG
Commit Message:
Line 16: This patch/fix isn't relevant to master/4.2 as the folders are created
Line 17: in master/4.2 via systemd-tmpfiles
Line 18: (https://gerrit.ovirt.org/#/c/69093/)
Line 19:
Line 20:
add LABEL: ovirt-4.1 ONLY
Line 21: Bug-Id: https://bugzilla.redhat.com/1437448
Line 22: Change-Id: I2da60e6e06b49f0d0bb2eb407d89dbefe8ded424
--
To view, visit https://gerrit.ovirt.org/76026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2da60e6e06b49f0d0bb2eb407d89dbefe8ded424
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[master]: api: log call context for api calls
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: api: log call context for api calls
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/75517/7/lib/vdsm/common/api.py
File lib/vdsm/common/api.py:
Line 57: if flow_id is not None:
Line 58: ret += ', flow_id=%s' % (flow_id,)
Line 59: return ret
Line 60: else:
Line 61: return 'from=internal'
please put the output print in the commit msg for both cases - when contxt is available and when its not
Line 62:
Line 63:
Line 64: def guard(*guarding_functions):
Line 65: """
--
To view, visit https://gerrit.ovirt.org/75517
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I128a338037b22b43b1065cfb40ea95de6f371b99
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[master]: api: adding context for api calls
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: api: adding context for api calls
......................................................................
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/75335/8//COMMIT_MSG
Commit Message:
Line 11: header and it is passed around in vdsm using threadlocal.
Line 12:
Line 13: The context that we pass consists of:
Line 14: - flow_id - uniquely identifies flow
Line 15: - client_host - host from where specific verb was called
fqdn or ip address? of the source? how local request are presented (localhost:54321)? how backward compatibility is handled when the context part is missing also should be mentioned here
Line 16: - client_port - which port was used to call the verb
Line 17:
Line 18:
Line 19: Bug-Url: https://bugzilla.redhat.com/1112120
https://gerrit.ovirt.org/#/c/75335/8/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 62:
Line 63: class Headers(object):
Line 64: CONTENT_LENGTH = "content-length"
Line 65: CONTENT_TYPE = "content-type"
Line 66: FLOW_ID = "ovirtCorrelationId"
why not ovirt-correlation-id as the rest of the headers?
Line 67: SUBSCRIPTION = "subscription"
Line 68: RECEIPT = "receipt"
Line 69: RECEIPT_ID = "receipt-id"
Line 70: DESTINATION = "destination"
--
To view, visit https://gerrit.ovirt.org/75335
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e73edc929e6d3e55d3f33a51229180ba35c52ac
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[master]: common: move thread local
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: common: move thread local
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/75516/5/vdsm/storage/volume.py
File vdsm/storage/volume.py:
Line 1: #
Line 2: # Copyright 2009-2016 Red Hat, Inc.
dates
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
--
To view, visit https://gerrit.ovirt.org/75516
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If041a1ce38087d209258dc1a7661161f8f65c03c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[master]: xmlrpc: remove transport verification
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: xmlrpc: remove transport verification
......................................................................
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/72769/8/lib/vdsm/m2cutils.py
File lib/vdsm/m2cutils.py:
Line 1: #
Line 2: # Copyright 2014 Red Hat, Inc.
Line 3: #
dates
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
Line 7: # (at your option) any later version.
--
To view, visit https://gerrit.ovirt.org/72769
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie469e81454abd6954861179c8a7494cc474f9db7
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month