Change in vdsm[master]: virt: metadata: update appendMetadataVDSM
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: metadata: update appendMetadataVDSM
......................................................................
virt: metadata: update appendMetadataVDSM
remimplement the method using the new metadata.py API.
Change-Id: Ie9114517ad70b509071a4f95e25d5c9e4cfe5a76
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/libvirtxml.py
1 file changed, 9 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/74219
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9114517ad70b509071a4f95e25d5c9e4cfe5a76
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: virt: metadata: update appendMetadataQOS
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: metadata: update appendMetadataQOS
......................................................................
virt: metadata: update appendMetadataQOS
reimplement the method using the new metadata.py API.
Change-Id: Id8d6ce720b9ab2cf4fc3b8598cf279da4a831059
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/libvirtxml.py
1 file changed, 18 insertions(+), 17 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/74218
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8d6ce720b9ab2cf4fc3b8598cf279da4a831059
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: virt: metadata: update appendMetadataContainer
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: metadata: update appendMetadataContainer
......................................................................
virt: metadata: update appendMetadataContainer
remimplement the method using the new metadata.py API.
Change-Id: I1b78a232ed957b3894ec325dee7784f45db589cd
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/containers/xmlfile.py
M lib/vdsm/virt/libvirtxml.py
M tests/containers/data/bridge_down.xml
M tests/containers/data/bridge_no_source.xml
M tests/containers/data/disk_dev.xml
M tests/containers/data/disk_file_malformed.xml
M tests/containers/data/full_dom.xml
M tests/containers/data/metadata_drive_map.xml
M tests/containers/data/minimal_dom.xml
M tests/containers/data/only_disk.xml
M tests/containers/data/only_mem.xml
M tests/vmxml_test.py
12 files changed, 71 insertions(+), 47 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/74220
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b78a232ed957b3894ec325dee7784f45db589cd
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: virt: add the metadata module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: add the metadata module
......................................................................
virt: add the metadata module
Add module to act as central facade for the libvirt domain metadata.
The module provides classes to get/set data from either ElementTree,
to be used in the VM run flow, or from a libvirt Domain object, to be
used once the VM is running (e.g. hot(un)plug flows).
We use a custom serialization formats which tries to be compact and
readable, while mimicing the current schema as much as we can.
The code adds type hints to the XML elements to be able
to unmarshal the correct python types.
The module intentionally doesn't do any validation.
Should schema validation be needed, we will add one specific step.
Notes:
1. at XML define time, we must take care of namespaces ourselves,
and add prefixes to all the elements we add in the metadata area.
2. once the domain is succesfully started, and we access the metadata
elements using dom.metadata() and dom.setMetadata(), libvirt takes
care automatically of prefixing elements (including all
subelements) with their namespace string; so we must NOT do that
ourselves, otherwise we can end up with something illegal like
ovirt-vm:ovirt-vm:vm
^ ^ ^
| | `- the element name the code wants to use
| `- added by this module
`- added by libvirt
3. the API was simplified to only take care of marshalling and
unmarshalling python key/values to XML. Since we either
disallow or completely control nesting (e.g. device metadata)
we don't need anything extra besides our existing XML
processing tools (e.g. no dependency on 3rd party complex libs).
Change-Id: Iab8a1a78a8efce3200e66285cc37211132fcb247
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/Makefile.am
A lib/vdsm/virt/metadata.py
A tests/virttests/metadata_test.py
M vdsm.spec.in
4 files changed, 480 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/74206
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab8a1a78a8efce3200e66285cc37211132fcb247
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: virt: metadata: update appendMetadataContainer
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: metadata: update appendMetadataContainer
......................................................................
Patch Set 17: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/74220
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b78a232ed957b3894ec325dee7784f45db589cd
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: virt: metadata: update appendMetadataVDSM
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: metadata: update appendMetadataVDSM
......................................................................
Patch Set 16: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/74219
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9114517ad70b509071a4f95e25d5c9e4cfe5a76
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: virt: metadata: update appendMetadataQOS
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: metadata: update appendMetadataQOS
......................................................................
Patch Set 16: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/74218
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8d6ce720b9ab2cf4fc3b8598cf279da4a831059
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: virt: add the metadata module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: add the metadata module
......................................................................
Patch Set 16: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/74206
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab8a1a78a8efce3200e66285cc37211132fcb247
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: net tests: libvirt_test - extract custom assertions
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: libvirt_test - extract custom assertions
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/74389
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I202d943136298200cbc03224b013493848886c81
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[ovirt-4.1]: Changing ntp requirement to chrony
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Changing ntp requirement to chrony
......................................................................
Changing ntp requirement to chrony
vdsm.service depends on time-sync.target, which means chronyd or ntpd
should run in parallel to it. chronyd is installed by default since fc18,
this requirement is needed for minimal distributions.
Change-Id: If588265cd7d100ab5d003ba9ec161151ea7dcb16
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1428419
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/74663/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index fd27d95..d8f535b 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -88,13 +88,13 @@
Requires: virt-v2v
%endif
+Requires: chrony
Requires: dbus-python
Requires: ethtool
Requires: which
Requires: sudo >= 1.7.3
Requires: logrotate
Requires: xz
-Requires: ntp
Requires: iproute >= 3.10.0
Requires: PyYAML
Requires: python-dateutil
--
To view, visit https://gerrit.ovirt.org/74663
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If588265cd7d100ab5d003ba9ec161151ea7dcb16
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
7 years, 1 month