Change in vdsm[master]: vmxml: move condition from appendNumaTune to buildDomainXML
by Martin Polednik
Martin Polednik has uploaded a new change for review.
Change subject: vmxml: move condition from appendNumaTune to buildDomainXML
......................................................................
vmxml: move condition from appendNumaTune to buildDomainXML
Having the condition that explicit numa tuning was requested in
buildDomainXML(vm.py) instead of appendNumaTune(vmxml.py) makes the
flow slightly more obvious and allows for work done by further patches
in the series.
Change-Id: I7141cfe8d5ed086dde884234990a3c00ddca2092
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M vdsm/virt/vm.py
M vdsm/virt/vmxml.py
2 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/61929/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 88d3d97..a78c1b1 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1518,7 +1518,8 @@
domxml.appendCpu()
- domxml.appendNumaTune()
+ if 'numaTune' in self.conf:
+ domxml.appendNumaTune()
domxml._appendAgentDevice(self._guestSocketFile.decode('utf-8'),
vmchannels.DEVICE_NAME)
diff --git a/vdsm/virt/vmxml.py b/vdsm/virt/vmxml.py
index d187992..4052228 100644
--- a/vdsm/virt/vmxml.py
+++ b/vdsm/virt/vmxml.py
@@ -501,14 +501,13 @@
</numatune>
"""
- if 'numaTune' in self.conf:
- numaTune = self.conf.get('numaTune')
- if 'nodeset' in numaTune.keys():
- mode = numaTune.get('mode', 'strict')
- numatune = Element('numatune')
- numatune.appendChildWithArgs('memory', mode=mode,
- nodeset=numaTune['nodeset'])
- self.dom.appendChild(numatune)
+ numaTune = self.conf.get('numaTune')
+ if 'nodeset' in numaTune.keys():
+ mode = numaTune.get('mode', 'strict')
+ numatune = Element('numatune')
+ numatune.appendChildWithArgs('memory', mode=mode,
+ nodeset=numaTune['nodeset'])
+ self.dom.appendChild(numatune)
def _appendAgentDevice(self, path, name):
"""
--
To view, visit https://gerrit.ovirt.org/61929
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7141cfe8d5ed086dde884234990a3c00ddca2092
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
7 years, 7 months
Change in vdsm[master]: hostdev: properly set is_hostdevice
by Martin Polednik
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: properly set is_hostdevice
......................................................................
hostdev: properly set is_hostdevice
Since we added is_hostdevice attribute to all devices, and the
attribute defaults to false, we have to explicitly set it to true for
host devices.
Change-Id: Ie4b70f698fb1e6d8a8adec650d5a91d8c8736676
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M vdsm/virt/vmdevices/hostdevice.py
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/62064/1
diff --git a/vdsm/virt/vmdevices/hostdevice.py b/vdsm/virt/vmdevices/hostdevice.py
index bfd7f45..8e0290c 100644
--- a/vdsm/virt/vmdevices/hostdevice.py
+++ b/vdsm/virt/vmdevices/hostdevice.py
@@ -40,6 +40,7 @@
self.hostAddress = self._deviceParams.get('address')
self.numa_node = self._deviceParams.get('numa_node', None)
self.name = self.device
+ self.is_hostdevice = True
def setup(self):
self.log.info('Detaching device %s from the host.' % self.device)
@@ -156,6 +157,7 @@
self.hostAddress = device_params.get('address')
self.numa_node = None
self.name = self.device
+ self.is_hostdevice = True
def setup(self):
detach_detachable(self.device)
@@ -246,6 +248,7 @@
self.name = self.device
self.bus_address, self.adapter = scsi_address_to_adapter(
self.hostAddress)
+ self.is_hostdevice = True
def setup(self):
detach_detachable(self.device)
--
To view, visit https://gerrit.ovirt.org/62064
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4b70f698fb1e6d8a8adec650d5a91d8c8736676
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
7 years, 7 months
Change in vdsm[master]: devices: add is_hostdevice attribute
by Martin Polednik
Martin Polednik has uploaded a new change for review.
Change subject: devices: add is_hostdevice attribute
......................................................................
devices: add is_hostdevice attribute
is_hostdevice attribute is currently used to determine whether given
device is so called host device, or in other words if it refers to
physical device.
At the moment, only devices HOSTDEV and NETWORK may be host devices,
but moving the attribute to interface level allows us to greatly
simplify host NUMA scheduling.
Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M vdsm/virt/vmdevices/core.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/62063/1
diff --git a/vdsm/virt/vmdevices/core.py b/vdsm/virt/vmdevices/core.py
index 1508b9d..90b8cd8 100644
--- a/vdsm/virt/vmdevices/core.py
+++ b/vdsm/virt/vmdevices/core.py
@@ -36,7 +36,8 @@
class Base(vmxml.Device):
__slots__ = ('deviceType', 'device', 'alias', 'specParams', 'deviceId',
- 'conf', 'log', '_deviceXML', 'type', 'custom')
+ 'conf', 'log', '_deviceXML', 'type', 'custom',
+ 'is_hostdevice')
def __init__(self, conf, log, **kwargs):
self.conf = conf
@@ -50,6 +51,7 @@
self.log.debug('Ignoring param (%s, %s) in %s', attr, value,
self.__class__.__name__)
self._deviceXML = None
+ self.is_hostdevice = False
def __str__(self):
attrs = [':'.join((a, str(getattr(self, a, None)))) for a in dir(self)
--
To view, visit https://gerrit.ovirt.org/62063
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
7 years, 7 months
Change in vdsm[master]: yml: return type fixes for StoragePool.getSpmStatus
by Piotr Kliczewski
Piotr Kliczewski has uploaded a new change for review.
Change subject: yml: return type fixes for StoragePool.getSpmStatus
......................................................................
yml: return type fixes for StoragePool.getSpmStatus
Change-Id: Ieb9fbae250507d4cf02ef9b73eee6403a06cd9d2
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M lib/api/vdsm-api.yml
M tests/vdsmapi_test.py
2 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/59706/1
diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index 20de0a6..7dd95d1 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -5468,7 +5468,7 @@
- description: The lock version of the Storage Pool
name: spmLver
- type: int
+ type: long
type: object
StorageDomainCreateArgumentsBlock: &StorageDomainCreateArgumentsBlock
diff --git a/tests/vdsmapi_test.py b/tests/vdsmapi_test.py
index c3cacf0..eddb735 100644
--- a/tests/vdsmapi_test.py
+++ b/tests/vdsmapi_test.py
@@ -601,3 +601,9 @@
_schema.schema().verify_retval(
vdsmapi.MethodRep('Task', 'getStatus'), ret)
+
+ def test_spm_status(self):
+ ret = {'spmId': 1, 'spmStatus': 'SPM', 'spmLver': 10}
+
+ _schema.schema().verify_retval(
+ vdsmapi.MethodRep('StoragePool', 'getSpmStatus'), ret)
--
To view, visit https://gerrit.ovirt.org/59706
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb9fbae250507d4cf02ef9b73eee6403a06cd9d2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
7 years, 7 months
Change in vdsm[master]: yml: return type fixes for Task.getStatus
by Piotr Kliczewski
Piotr Kliczewski has uploaded a new change for review.
Change subject: yml: return type fixes for Task.getStatus
......................................................................
yml: return type fixes for Task.getStatus
Change-Id: I7ce3e3ab2e21e5d1f6da6bdf5dc89a3db40e2160
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M lib/api/vdsm-api.yml
M tests/vdsmapi_test.py
2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/59705/1
diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index 670eed7..20de0a6 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -5818,6 +5818,7 @@
cleanFailure: The task failed and recovery also failed
cleanSuccess: The task failed but was successfully recovered
success: The task was successful
+ '': Task is in progress
TaskState: &TaskState
added: '3.1'
diff --git a/tests/vdsmapi_test.py b/tests/vdsmapi_test.py
index 04297b1..c3cacf0 100644
--- a/tests/vdsmapi_test.py
+++ b/tests/vdsmapi_test.py
@@ -591,3 +591,13 @@
_schema.schema().verify_args(
vdsmapi.MethodRep('StoragePool', 'spmStart'), params)
+
+ def test_task_status(self):
+ ret = {'code': 0,
+ 'message': 'running job 1 of 1',
+ 'taskState': 'running',
+ 'taskResult': '',
+ 'taskID': '72fdf1ca-8826-4688-9c8c-e175d4253e2a'}
+
+ _schema.schema().verify_retval(
+ vdsmapi.MethodRep('Task', 'getStatus'), ret)
--
To view, visit https://gerrit.ovirt.org/59705
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ce3e3ab2e21e5d1f6da6bdf5dc89a3db40e2160
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
7 years, 7 months
Change in vdsm[master]: yml: parameter type fixes for StoragePool.spmStart
by Piotr Kliczewski
Piotr Kliczewski has uploaded a new change for review.
Change subject: yml: parameter type fixes for StoragePool.spmStart
......................................................................
yml: parameter type fixes for StoragePool.spmStart
Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M lib/api/vdsm-api.yml
M tests/vdsmapi_test.py
2 files changed, 17 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/59704/1
diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index a289b7f..670eed7 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -8602,11 +8602,13 @@
- description: Deprecated. The lver of the previous SPM
name: prevLver
- type: int
+ type: string
+ datatype: int
- description: This parameter is not used
name: enableScsiFencing
- type: boolean
+ type: string
+ datatype: boolean
- defaultvalue: null
description: The maximum number of hosts that could be in the cluster
@@ -8616,7 +8618,8 @@
- defaultvalue: null
description: The expected Storage Domain version of the master domain
name: domVersion
- type: int
+ type: string
+ datatype: int
return:
description: A task UUID
type: *UUID
diff --git a/tests/vdsmapi_test.py b/tests/vdsmapi_test.py
index bff578c..04297b1 100644
--- a/tests/vdsmapi_test.py
+++ b/tests/vdsmapi_test.py
@@ -580,3 +580,14 @@
_schema.schema().verify_retval(
vdsmapi.MethodRep('Host', 'hostdevListByCaps'), ret)
+
+ def test_start_spm(self):
+ params = {u'prevLver': u'-1',
+ u'enableScsiFencing': u'false',
+ u'storagepoolID': u'636d9c59-f7ba-4115-87a1-44d6563a9610',
+ u'prevID': -1,
+ u'domVersion': u'3',
+ u'maxHostID': 250}
+
+ _schema.schema().verify_args(
+ vdsmapi.MethodRep('StoragePool', 'spmStart'), params)
--
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
7 years, 7 months
Change in vdsm[master]: core: Unlink image run directory when deleting a snapshot
by ahino@redhat.com
Ala Hino has uploaded a new change for review.
Change subject: core: Unlink image run directory when deleting a snapshot
......................................................................
core: Unlink image run directory when deleting a snapshot
Unlink image run directory,
/run/vdsm/storage/sdUUID/imgUUID/volUUID, when removing a
snapshot.
Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4
Bug-Url: https://bugzilla.redhat.com/1321018
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M vdsm/storage/blockVolume.py
1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/59725/1
diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py
index 4476a9e..080a858 100644
--- a/vdsm/storage/blockVolume.py
+++ b/vdsm/storage/blockVolume.py
@@ -604,12 +604,22 @@
try:
self.log.debug("Unlinking %s", vol_path)
os.unlink(vol_path)
- return True
except Exception as e:
eFound = e
self.log.error("cannot delete volume's %s/%s link path: %s",
self.sdUUID, self.volUUID, vol_path, exc_info=True)
+ try:
+ imgRundir = os.path.join(constants.P_VDSM_STORAGE, self.sdUUID,
+ self.imgUUID, self.volUUID)
+ self.log.debug("Unlinking %s", imgRundir)
+ os.unlink(imgRundir)
+ return True
+ except Exception as e:
+ eFound = e
+ self.log.error("cannot delete volume's %s/%s link path: %s",
+ self.sdUUID, self.volUUID, imgRundir, exc_info=True)
+
raise eFound
def extend(self, newSize):
--
To view, visit https://gerrit.ovirt.org/59725
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
7 years, 8 months
Change in vdsm[ovirt-3.5]: spec: Require sanlock 2.8-3
by Nir Soffer
Nir Soffer has uploaded a new change for review.
Change subject: spec: Require sanlock 2.8-3
......................................................................
spec: Require sanlock 2.8-3
Sanlock 2.8-3 added missing dependency on /usr/sbin/useradd and
/usr/sbin/groupadd, used to add the sanlock user and group during
installation. Without these dependencies, sanlock installation fail to
add the user and group, which fail vdsm-tool configure later.
Change-Id: I83ad11eda2695f161ee294571bbacbac11586b83
Bug-Url: https://bugzilla.redhat.com/1349068
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/59656/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 607532f..7f968bd 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -216,7 +216,7 @@
Requires: iscsi-initiator-utils >= 6.2.0.873-21
%endif
-Requires: sanlock >= 2.8, sanlock-python
+Requires: sanlock >= 2.8-3, sanlock-python
%if 0%{?rhel}
Requires: python-ethtool >= 0.6-3
--
To view, visit https://gerrit.ovirt.org/59656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83ad11eda2695f161ee294571bbacbac11586b83
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
7 years, 8 months
Change in vdsm[ovirt-3.6]: spec: Require ioprocess 0.15.2
by Nir Soffer
Nir Soffer has uploaded a new change for review.
Change subject: spec: Require ioprocess 0.15.2
......................................................................
spec: Require ioprocess 0.15.2
The first time IOProcess.truncate() or IOProcess.touch() is called,
ioprocess keep the file open and will never close it.
Typically when using with vdsm, ioprocess will keep the
__DIRECT_IO_TEST__ file open on shared storage, since the first thing
vdsm does is touching this file.
Keeping open files on shared storage may prevent activation of a storage
domain after it was deactivated.
This is a 3.6 only patch, 4.0 already requires ioprocess 0.16.1
containing this fix.
Change-Id: Ia1fba8f5bfb84e9ff60478e36a09f1690ca6989a
Bug-Url: https://bugzilla.redhat.com/1370564
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/63038/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index eaa7089..28188ac 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -90,7 +90,7 @@
BuildRequires: psmisc
BuildRequires: python-cpopen >= 1.3
BuildRequires: python-inotify
-BuildRequires: python-ioprocess >= 0.15.0-4
+BuildRequires: python-ioprocess >= 0.15.2
BuildRequires: python-pthreading
BuildRequires: qemu-img
BuildRequires: rpm-python
@@ -122,7 +122,7 @@
Requires: python-inotify
Requires: python-argparse
Requires: python-cpopen >= 1.3
-Requires: python-ioprocess >= 0.15.0-4
+Requires: python-ioprocess >= 0.15.2
Requires: python-pthreading >= 0.1.3-3
Requires: python-six
Requires: python-requests
@@ -311,7 +311,7 @@
Requires: %{name}-infra = %{version}-%{release}
Requires: python-cpopen >= 1.2.3-5
Requires: m2crypto
-Requires: python-ioprocess >= 0.15.0-4
+Requires: python-ioprocess >= 0.15.2
%description python
Shared libraries between the various VDSM packages.
--
To view, visit https://gerrit.ovirt.org/63038
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1fba8f5bfb84e9ff60478e36a09f1690ca6989a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
7 years, 8 months
Change in vdsm[master]: network: Use new concurrent.thread() utility
by Nir Soffer
Nir Soffer has uploaded a new change for review.
Change subject: network: Use new concurrent.thread() utility
......................................................................
network: Use new concurrent.thread() utility
This patch updates the networking subsystem to use the new utility.
Behavior changes:
- dhclient.DhcpClient threads are protected from silent failures
- configurators/ifcfg._ifup threads are proected from silent
failures.
Change-Id: I62e80bbbb9354d3173cce631ed5579532cf7cdcb
Relates-To: https://bugzilla.redhat.com/1141422
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/network/configurators/dhclient.py
M vdsm/network/configurators/ifcfg.py
M vdsm/network/sourceroutethread.py
3 files changed, 8 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/45553/1
diff --git a/vdsm/network/configurators/dhclient.py b/vdsm/network/configurators/dhclient.py
index 181c302..a25ae8f 100644
--- a/vdsm/network/configurators/dhclient.py
+++ b/vdsm/network/configurators/dhclient.py
@@ -23,8 +23,8 @@
import logging
import os
import signal
-import threading
+from vdsm import concurrent
from vdsm import cmdutils
from vdsm import ipwrapper
from vdsm import netinfo
@@ -76,9 +76,8 @@
rc, _, _ = self._dhclient()
return rc
else:
- t = threading.Thread(target=self._dhclient, name='vdsm-dhclient-%s'
- % self.iface)
- t.daemon = True
+ t = concurrent.thread(self._dhclient,
+ name='vdsm-dhclient-%s' % self.iface)
t.start()
def shutdown(self):
diff --git a/vdsm/network/configurators/ifcfg.py b/vdsm/network/configurators/ifcfg.py
index e1d3e94..f676f83 100644
--- a/vdsm/network/configurators/ifcfg.py
+++ b/vdsm/network/configurators/ifcfg.py
@@ -28,11 +28,11 @@
import re
import selinux
import shutil
-import threading
from libvirt import libvirtError, VIR_ERR_NO_NETWORK
from vdsm.config import config
+from vdsm import concurrent
from vdsm import cmdutils
from vdsm import constants
from vdsm import ipwrapper
@@ -782,9 +782,8 @@
if not iface.blockingdhcp and (iface.ipv4.bootproto == 'dhcp' or
iface.ipv6.dhcpv6):
# wait for dhcp in another thread, so vdsm won't get stuck (BZ#498940)
- t = threading.Thread(target=_exec_ifup, name='ifup-waiting-on-dhcp',
- args=(iface.name, cgroup))
- t.daemon = True
+ t = concurrent.thread(_exec_ifup, name='ifup-waiting-on-dhcp',
+ args=(iface.name, cgroup))
t.start()
else:
_exec_ifup(iface.name, cgroup)
diff --git a/vdsm/network/sourceroutethread.py b/vdsm/network/sourceroutethread.py
index 0a49760..042e5bd 100644
--- a/vdsm/network/sourceroutethread.py
+++ b/vdsm/network/sourceroutethread.py
@@ -19,12 +19,11 @@
from __future__ import absolute_import
import logging
import os
-import threading
import pyinotify
from vdsm.constants import P_VDSM_RUN
-from vdsm import utils
+from vdsm import concurrent
from .configurators.iproute2 import Iproute2
from .sourceroute import DynamicSourceRoute
@@ -68,13 +67,10 @@
def start():
- thread = threading.Thread(target=_subscribeToInotifyLoop,
- name='sourceRoute')
- thread.daemon = True
+ thread = concurrent.thread(_subscribeToInotifyLoop, name='sourceRoute')
thread.start()
-(a)utils.traceback()
def _subscribeToInotifyLoop():
logging.debug("sourceRouteThread.subscribeToInotifyLoop started")
--
To view, visit https://gerrit.ovirt.org/45553
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I62e80bbbb9354d3173cce631ed5579532cf7cdcb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
7 years, 8 months