Change in vdsm[master]: supervdsm net: Fix supervdsm_server, restoring NM init call
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: supervdsm net: Fix supervdsm_server, restoring NM init call
......................................................................
supervdsm net: Fix supervdsm_server, restoring NM init call
Patch 27023f32197f22445a23710e689455df164e687e has dropped the NM
initialization.
Restoring the NM init call.
Change-Id: If8f490f6648e6c7a4ec440ee9efb99948f9db419
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/supervdsm_server.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/69260
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8f490f6648e6c7a4ec440ee9efb99948f9db419
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in vdsm[master]: storage_mailbox: make inbox/outbox mailbox args
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: storage_mailbox: make inbox/outbox mailbox args
......................................................................
Patch Set 2:
ci please build
--
To view, visit https://gerrit.ovirt.org/69157
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5524d83e72eed7c7286dacdd30eb502500c04d72
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: utils: remove remaining ovirt node legacy code
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: remove remaining ovirt node legacy code
......................................................................
utils: remove remaining ovirt node legacy code
isOvirtNode, persist and unpersist are legacy code.
oVirt Node Next should be like any other distro.
This patch removes the legacy code.
Change-Id: I40f9476f19ac8c8e7383b908e51933912be90bb1
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M lib/vdsm/utils.py
1 file changed, 0 insertions(+), 15 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/68022
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40f9476f19ac8c8e7383b908e51933912be90bb1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in vdsm[master]: utils: remove remaining ovirt node legacy code
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: utils: remove remaining ovirt node legacy code
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/68022
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40f9476f19ac8c8e7383b908e51933912be90bb1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: net: introducing normalize_literal_addr
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: introducing normalize_literal_addr
......................................................................
net: introducing normalize_literal_addr
the method receives a valid ip address, and returns it in its literal
form.
ipv4 addresses are effectively remaining unchanged, however ipv6
addresses may need to be enclosed with square brackets (in accordance
with rfc2732) in order to able to be used in uri/urls.
an immediate use for this method is making sure qemu uri's will hold
valid addresses.
Change-Id: Ibb519853e1e0b7f3036845bada4db38053fafd35
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M lib/vdsm/common/network/address.py
M tests/common/network_test.py
2 files changed, 33 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Leon Goldberg: Verified
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/69224
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb519853e1e0b7f3036845bada4db38053fafd35
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in vdsm[master]: net: introducing normalize_literal_addr
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: introducing normalize_literal_addr
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/69224
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb519853e1e0b7f3036845bada4db38053fafd35
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: storage_mailbox_test: test send/receive
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: storage_mailbox_test: test send/receive
......................................................................
storage_mailbox_test: test send/receive
The added test sends an xtnd message from to an hsm mailbox, and waits
until the spm mailbox processes it (or timeout expires).
In order to add the test I needed to set a proper size to the inbox and
outbox, as well as to place them on a non-tmpfs filesystem.
Change-Id: I46be970d1cf0c9e495e69185d8eeb8ebb68d991b
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/storage_mailbox_test.py
1 file changed, 48 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/68589/1
diff --git a/tests/storage_mailbox_test.py b/tests/storage_mailbox_test.py
index de21e73..2525791 100644
--- a/tests/storage_mailbox_test.py
+++ b/tests/storage_mailbox_test.py
@@ -18,6 +18,7 @@
# Refer to the README and COPYING files for full details of the license
#
+from contextlib import contextmanager
import threading
import os
import shutil
@@ -27,14 +28,17 @@
import storage.storage_mailbox as sm
from storage.sd import DOMAIN_META_DATA
+from vdsm.config import config
from vdsm.utils import retry
import tempfile
+
+MAX_HOSTS = 10
class StoragePoolStub(object):
def __init__(self):
self.spUUID = make_uuid()
- self.storage_repository = tempfile.mkdtemp()
+ self.storage_repository = tempfile.mkdtemp(dir='/var/tmp')
def __enter__(self):
masterdir = os.path.join(
@@ -44,7 +48,7 @@
for fname in ["id", "inbox", "outbox"]:
with open(os.path.join(masterdir, fname), "w") as f:
- f.write("DATA")
+ f.write(sm.EMPTYMAILBOX * MAX_HOSTS)
return self
@@ -55,10 +59,51 @@
class SPM_MailMonitorTests(TestCaseBase):
def testThreadLeak(self):
with StoragePoolStub() as pool:
- mailer = sm.SPM_MailMonitor(pool, 100)
+ mailer = sm.SPM_MailMonitor(pool, MAX_HOSTS)
threadCount = len(threading.enumerate())
mailer.stop()
mailer.run()
t = lambda: self.assertEquals(threadCount, len(threading.enumerate()))
retry(AssertionError, t, timeout=4, sleep=0.1)
+
+
+@contextmanager
+def patch_config(config, section, key, value):
+ oldvalue = config.get(section, key)
+ config.set(section, key, value)
+ yield
+ config.set(section, key, oldvalue)
+
+
+class MailboxTests(TestCaseBase):
+ def test_send_receive(self):
+ msg_processed = threading.Event()
+ expired = False
+
+ def spm_callback(msg_id, data):
+ msg_processed.set()
+
+ with StoragePoolStub() as pool:
+ with patch_config(config, 'irs',
+ 'repository', pool.storage_repository):
+ hsm_mb = sm.HSM_Mailbox(hostID=7, poolID=pool.spUUID)
+ spm_mb = sm.SPM_MailMonitor(pool, MAX_HOSTS)
+ spm_mb.registerMessageType('xtnd', spm_callback)
+ spm_mb_thread = threading.Thread(target=spm_mb.run)
+ spm_mb_thread.start()
+ try:
+ vol_data = dict(
+ poolID=pool.spUUID, domainID=make_uuid(),
+ volumeID=make_uuid())
+ hsm_mb.sendExtendMsg(vol_data, 100)
+
+ if not msg_processed.wait(3):
+ expired = True
+
+ hsm_mb.stop()
+ spm_mb.stop()
+ finally:
+ spm_mb_thread.join()
+
+ self.assertFalse(expired, 'message was not processed on time')
--
To view, visit https://gerrit.ovirt.org/68589
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46be970d1cf0c9e495e69185d8eeb8ebb68d991b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 5 months
Change in vdsm[master]: travis: Add Fedora 25 build
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: travis: Add Fedora 25 build
......................................................................
travis: Add Fedora 25 build
Change-Id: I6961cc3cdf531d9e9347a2c462a364bba465516a
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M .travis.yml
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/69206
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6961cc3cdf531d9e9347a2c462a364bba465516a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in vdsm[master]: docker: Add Fedora 25 image
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: docker: Add Fedora 25 image
......................................................................
docker: Add Fedora 25 image
This is mostly the same as the Fedora 24 dockerfile, replacing
python-blivet with python-blivet1 (legacy version created for us).
Change-Id: Id2b2ed9cc0655f280f8a8d45f30b43063ca50bd6
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
R docker/Dockerfile.fedora.24
A docker/Dockerfile.fedora.25
2 files changed, 51 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/69205
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2b2ed9cc0655f280f8a8d45f30b43063ca50bd6
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months