Nir Soffer has uploaded a new change for review.
Change subject: tests: Fail if abort was not called
......................................................................
tests: Fail if abort was not called
The StuckJob was waiting one second and terminating silently even if the
test never called abort. Now we raise RuntimeError in this case.
Change-Id: If71d2aeeb4a4242678253845071f68f3a9b12f5d
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M tests/jobsTests.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/65207/1
diff --git a/tests/jobsTests.py b/tests/jobsTests.py
index 3b39277..520c98d 100644
--- a/tests/jobsTests.py
+++ b/tests/jobsTests.py
@@ -85,7 +85,8 @@
def _run(self):
self.event_running.set()
- self.event_aborted.wait(1)
+ if not self.event_aborted.wait(1):
+ raise RuntimeError("Timeout waiting for abort")
def _abort(self):
self.event_aborted.set()
--
To view, visit https://gerrit.ovirt.org/65207
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If71d2aeeb4a4242678253845071f68f3a9b12f5d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
gerrit-hooks has posted comments on this change.
Change subject: properties: py3: properties.py and properties_test.py compliance
......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/63230
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3f49dd718d786c4a98b06c7b8757ce5a9eb6d2a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
Nir Soffer has abandoned this change.
Change subject: properties: py3: properties.py and properties_test.py compliance
......................................................................
Abandoned
All the changes in this patch are already merged in separate patches.
--
To view, visit https://gerrit.ovirt.org/63230
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Id3f49dd718d786c4a98b06c7b8757ce5a9eb6d2a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>