Change in vdsm[master]: domain: unify the createVolume method
by Federico Simoncelli
Federico Simoncelli has uploaded a new change for review.
Change subject: domain: unify the createVolume method
......................................................................
domain: unify the createVolume method
Change-Id: I03eeaa2561fd13b4094634f5cfeee644d6396a18
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M vdsm/storage/blockSD.py
M vdsm/storage/fileSD.py
M vdsm/storage/sd.py
3 files changed, 4 insertions(+), 22 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/13329/1
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index 9809bf4..8add58c 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -629,16 +629,6 @@
blockVolume.BlockVolume.validateCreateVolumeParams(
volFormat, preallocate, srcVolUUID)
- def createVolume(self, imgUUID, size, volFormat, preallocate, diskType,
- volUUID, desc, srcImgUUID, srcVolUUID):
- """
- Create a new volume
- """
- repoPath = self._getRepoPath()
- return blockVolume.BlockVolume.create(
- repoPath, self.sdUUID, imgUUID, size, volFormat, preallocate,
- diskType, volUUID, desc, srcImgUUID, srcVolUUID)
-
@classmethod
def getMetaDataMapping(cls, vgName, oldMapping={}):
firstDev, firstExtent = lvm.getFirstExt(vgName, sd.METADATA)
diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py
index be2a793..27991f9 100644
--- a/vdsm/storage/fileSD.py
+++ b/vdsm/storage/fileSD.py
@@ -287,17 +287,6 @@
fileVolume.FileVolume.validateCreateVolumeParams(
volFormat, preallocate, srcVolUUID)
- def createVolume(self, imgUUID, size, volFormat, preallocate,
- diskType, volUUID, desc, srcImgUUID, srcVolUUID):
- """
- Create a new volume
- """
- repoPath = self._getRepoPath()
- return fileVolume.FileVolume.create(
- repoPath, self.sdUUID,
- imgUUID, size, volFormat, preallocate, diskType,
- volUUID, desc, srcImgUUID, srcVolUUID)
-
def getVolumeLease(self, imgUUID, volUUID):
"""
Return the volume lease (leasePath, leaseOffset)
diff --git a/vdsm/storage/sd.py b/vdsm/storage/sd.py
index 48ee7d5..249f076 100644
--- a/vdsm/storage/sd.py
+++ b/vdsm/storage/sd.py
@@ -397,7 +397,10 @@
"""
Create a new volume
"""
- pass
+ volClass = getVolumeClass()
+ return volClass.create(self._getRepoPath(), self.sdUUID, imgUUID,
+ size, volFormat, preallocate, diskType, volUUID, desc, srcImgUUID,
+ srcVolUUID)
def getMDPath(self):
if self.domaindir:
--
To view, visit http://gerrit.ovirt.org/13329
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I03eeaa2561fd13b4094634f5cfeee644d6396a18
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
11 years
Change in vdsm[master]: SUDO change, move fuser call to super vdsm
by xiawenc@linux.vnet.ibm.com
Wenchao Xia has uploaded a new change for review.
Change subject: SUDO change, move fuser call to super vdsm
......................................................................
SUDO change, move fuser call to super vdsm
supervdsm.fuser() will return out result from executing, and
fuser.py will parse it.
Change-Id: I0bb881e6bcad213db1d186e70f41b22d78ee3ecf
Signed-off-by: wenchao xia <xiawenc(a)linux.vnet.ibm.com>
---
M vdsm/storage/fuser.py
M vdsm/supervdsmServer.py
2 files changed, 20 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/5314/1
--
To view, visit http://gerrit.ovirt.org/5314
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bb881e6bcad213db1d186e70f41b22d78ee3ecf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
11 years
Change in vdsm[master]: Added unit test libvirtvmTests.py:TestLibvirtvm.testBuildCmd...
by Jenkins CI RO
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Added unit test libvirtvmTests.py:TestLibvirtvm.testBuildCmdLine
......................................................................
Patch Set 7:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2163/ (2/2)
--
To view, visit http://gerrit.ovirt.org/14111
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74b898a6398a72608d7933009644703aa3f8d831
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maciej Lichon <maciej.lichon.wroclaw(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Maciej Lichon <maciej.lichon.wroclaw(a)gmail.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years