Change in vdsm[master]: Probe cpu count from new libvirt capabilities.
by Douglas Schilling Landgraf
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Probe cpu count from new libvirt capabilities.
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11709
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e4a08cfcde6fb2e1ce4cf10478af72217c20ba5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in vdsm[master]: Check that underlying filesystem supports direct IO before c...
by smizrahi@redhat.com
Saggi Mizrahi has uploaded a new change for review.
Change subject: Check that underlying filesystem supports direct IO before creating a domain on it
......................................................................
Check that underlying filesystem supports direct IO before creating a domain on it
Change-Id: Icf14d1c4737a88e693e5bebb896aef382b8b424c
Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com>
---
M vdsm/storage/fileSD.py
1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/9749/1
diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py
index c4415da..ac516ac 100644
--- a/vdsm/storage/fileSD.py
+++ b/vdsm/storage/fileSD.py
@@ -122,7 +122,6 @@
FileSDMetadata = lambda metafile: DictValidator(
PersistentDict(FileMetadataRW(metafile)), FILE_SD_MD_FIELDS)
-
class FileStorageDomain(sd.StorageDomain):
def __init__(self, domainPath):
# Using glob might look like the simplest thing to do but it isn't
@@ -134,6 +133,8 @@
self.metafile = os.path.join(domainPath, sd.DOMAIN_META_DATA,
sd.METADATA)
+ self.validateFileSystemFeatures()
+
metadata = FileSDMetadata(self.metafile)
sdUUID = metadata[sd.DMDK_SDUUID]
domaindir = os.path.join(self.mountpoint, sdUUID)
@@ -144,6 +145,20 @@
self.imageGarbageCollector()
self._registerResourceNamespaces()
+ def validateFileSystemFeatures(self):
+ testFilePath = os.path.join(self.mountpoint, "__DIRECTIO_TEST__")
+ try:
+ oop.getProcessPool(self.sdUUID).directWriteLines(testFilePath)
+ except OSError as e:
+ if e.errno == errno.EINVAL:
+ self.log.error("Underlying file system doesn't support"
+ "direct IO")
+ raise se.StorageDomainCreationError()
+
+ raise
+ finally:
+ oop.getProcessPool(self.sdUUID).os.unlink(testFilePath)
+
def setMetadataPermissions(self):
procPool = oop.getProcessPool(self.sdUUID)
for metaFile in (sd.LEASES, sd.IDS, sd.INBOX, sd.OUTBOX):
--
To view, visit http://gerrit.ovirt.org/9749
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf14d1c4737a88e693e5bebb896aef382b8b424c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
11 years, 4 months
Change in vdsm[master]: doc: Solved sphinx-build import errors.
by smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: doc: Solved sphinx-build import errors.
......................................................................
Patch Set 3: Fails
--
To view, visit http://gerrit.ovirt.org/11652
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I836210fa5bbd844c20b3b5444be24cd9fa4023e2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <giuseppevallarelli(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <giuseppevallarelli(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in vdsm[master]: doc: Solved sphinx-build import errors.
by smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: doc: Solved sphinx-build import errors.
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File doc/Makefile
Line 2: #
Line 3:
Line 4: # You can set these variables from the command line.
Line 5: SPHINXOPTS =
Line 6: SPHINXBUILD = PYTHONPATH=../vdsm:$$PYTHONPATH sphinx-build
For me it still spews errors unless I put
PYTHONPATH=../vdsm:../$$PYTHONPATH sphink-build
Line 7: PAPER =
Line 8: BUILDDIR = build
Line 9:
Line 10: # Internal variables.
--
To view, visit http://gerrit.ovirt.org/11652
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I836210fa5bbd844c20b3b5444be24cd9fa4023e2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <giuseppevallarelli(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <giuseppevallarelli(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in vdsm[master]: doc: Reorganized doc structure in root project folder
by smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: doc: Reorganized doc structure in root project folder
......................................................................
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11627
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f169fa3b70269f24b10ee399bcac7cfa12e5695
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <giuseppevallarelli(a)gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in vdsm[master]: doc: Solved sphinx-build import errors.
by smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: doc: Solved sphinx-build import errors.
......................................................................
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11652
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I836210fa5bbd844c20b3b5444be24cd9fa4023e2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <giuseppevallarelli(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <giuseppevallarelli(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months