Change in vdsm[master]: Fix the rest of vdsm storage pep8 issues.
by asegurap@redhat.com
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix the rest of vdsm storage pep8 issues.
......................................................................
Patch Set 1:
Thanks for the review and verification Zheng!
--
To view, visit http://gerrit.ovirt.org/10742
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I246024ef8de59a357504b5101cbada24aaaa80a2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in vdsm[master]: vdsm.spec: Don't require python-ordereddict on fedora
by wudxw@linux.vnet.ibm.com
Mark Wu has uploaded a new change for review.
Change subject: vdsm.spec: Don't require python-ordereddict on fedora
......................................................................
vdsm.spec: Don't require python-ordereddict on fedora
It is a regression introduced by commit bb0620f. The condition "0%{?rhel} < 7"
also holds true on fedora, so it causes to require python-ordereddict on fedora
Change-Id: I87e167f207669f4dda5bb71d7809fe301ea7e905
Signed-off-by: Mark Wu <wudxw(a)linux.vnet.ibm.com>
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/10703/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 75d6089..c9b51c0 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -47,7 +47,7 @@
%ifarch x86_64
BuildRequires: python-dmidecode
%endif
-%if 0%{?rhel} < 7
+%if 0%{?rhel} == 6
BuildRequires: python-ordereddict
%endif
@@ -186,7 +186,7 @@
BuildArch: noarch
Requires: %{name}-python = %{version}-%{release}
-%if 0%{?rhel} < 7
+%if 0%{?rhel} == 6
Requires: python-ordereddict
%endif
--
To view, visit http://gerrit.ovirt.org/10703
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87e167f207669f4dda5bb71d7809fe301ea7e905
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
11 years, 4 months
Change in vdsm[master]: Fix the rest of vdsm storage pep8 issues.
by zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Fix the rest of vdsm storage pep8 issues.
......................................................................
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10742
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I246024ef8de59a357504b5101cbada24aaaa80a2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in vdsm[master]: Fix the rest of vdsm storage pep8 issues.
by asegurap@redhat.com
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix the rest of vdsm storage pep8 issues.
......................................................................
Patch Set 1:
Output of gitpydiff for helping verification:
antoni@nx01 ~/code/vdsm> gitpydiff
checking vdsm/storage/dispatcher.py
checking vdsm/storage/image.py
checking vdsm/storage/iscsi.py
1 difference(s)
first file: vdsm/storage/iscsi.py
second file: /tmp/pydiff/vdsm/storage/iscsi.py
((273, '=='), (279, 'is'))
checking vdsm/storage/resourceManager.py
2 difference(s)
first file: vdsm/storage/resourceManager.py
second file: /tmp/pydiff/vdsm/storage/resourceManager.py
((370, '=='), (394, 'is'))
((372, '=='), (396, 'is'))
checking vdsm/storage/sp.py
4 difference(s)
first file: vdsm/storage/sp.py
second file: /tmp/pydiff/vdsm/storage/sp.py
((1437, '!='), (1501, 'is not'))
((1437, '!='), (1502, 'is not'))
((1450,
"VG %s's metadata size exceeded critical size: mdasize=%s mdafree=%s"),
(1516, "VG %s's metadata size exceeded critical size: mdasize=%s mdafree=%s"))
((1931, '=='), (2052, 'is'))
checking vdsm/storage/storage_mailbox.py
checking vdsm/storage/threadPool.py
3 difference(s)
first file: vdsm/storage/threadPool.py
second file: /tmp/pydiff/vdsm/storage/threadPool.py
((111,
"Compare(Getattr(Name('self'), '__isJoining'), [('==', Name('True'))])"),
(112, "Getattr(Name('self'), '__isJoining')"))
((196, "Compare(Getattr(Name('self'), '__isDying'), [('==', Name('True'))])"),
(198, "Getattr(Name('self'), '__isDying')"))
((191, "Compare(Getattr(Name('self'), '__isDying'), [('==', Name('False'))])"),
(193, "Not(Getattr(Name('self'), '__isDying'))"))
antoni@nx01 ~/code/vdsm>
--
To view, visit http://gerrit.ovirt.org/10742
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I246024ef8de59a357504b5101cbada24aaaa80a2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months