Change in vdsm[master]: BZ#840594 Fix netinfo when libvirt bridge does not exist.
by asegurap@redhat.com
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: BZ#840594 Fix netinfo when libvirt bridge does not exist.
......................................................................
BZ#840594 Fix netinfo when libvirt bridge does not exist.
In the case where a bridge that is configured in libvirt is manually removed or
renamed, netinfo throws an exception when trying to discover which ports are
assigned to the bridge.
This patch catches the OSError exception of trying to list the ports of a non-
existing bridge interface, effectively filtering the non-existing interface
from the network capabilities.
Change-Id: I2538a8ce2fafd8efed834b87b20a63d058afd96b
Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com>
---
M vdsm/netinfo.py
1 file changed, 14 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/7127/1
diff --git a/vdsm/netinfo.py b/vdsm/netinfo.py
index 4fbd13a..40483ed 100644
--- a/vdsm/netinfo.py
+++ b/vdsm/netinfo.py
@@ -19,6 +19,7 @@
#
import os
+import errno
import glob
import ethtool
import shlex
@@ -241,10 +242,19 @@
nets = networks()
for netname in nets.iterkeys():
if nets[netname]['bridged']:
- devname = netname
- d['networks'][netname] = { 'ports': ports(devname),
- 'stp': bridge_stp_state(devname),
- 'cfg': getIfaceCfg(devname), }
+ try:
+ devname = netname
+ d['networks'][netname] = { 'ports': ports(devname),
+ 'stp': bridge_stp_state(devname),
+ 'cfg': getIfaceCfg(devname), }
+ except OSError, e:
+ # If the bridge reported by libvirt does not exist anymore, do
+ # not report it, as this already assures that the bridge is not
+ # added d['networks']
+ if e == errno.ENOENT:
+ continue
+ else:
+ raise
else:
devname = nets[netname]['iface']
d['networks'][netname] = {}
--
To view, visit http://gerrit.ovirt.org/7127
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2538a8ce2fafd8efed834b87b20a63d058afd96b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
11 years, 10 months
Change in vdsm[master]: Skip broken tests feature
by smizrahi@redhat.com
Saggi Mizrahi has uploaded a new change for review.
Change subject: Skip broken tests feature
......................................................................
Skip broken tests feature
We can't have broken tests upstream, it confuses people who write
patches and makes them think they broke the functionality.
Add this to tests you know are broken to help others
Change-Id: Ia380b2a5f5027e88926f61f4a762c1afec9f0203
Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com>
---
M tests/alignmentScanTests.py
M tests/testValidation.py
2 files changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/3966/1
--
To view, visit http://gerrit.ovirt.org/3966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia380b2a5f5027e88926f61f4a762c1afec9f0203
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
11 years, 10 months
Change in vdsm[master]: (WIP) BZ#832765 - Rewrite vdsm-restore-net-config as python ...
by Igor Lvovsky
Igor Lvovsky has uploaded a new change for review.
Change subject: (WIP) BZ#832765 - Rewrite vdsm-restore-net-config as python module
......................................................................
(WIP) BZ#832765 - Rewrite vdsm-restore-net-config as python module
Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5
Signed-off-by: Igor Lvovsky <ilvovsky(a)redhat.com>
---
M vdsm/Makefile.am
A vdsm/vdsm-restore-net-config
D vdsm/vdsm-restore-net-config.in
M vdsm/vdsmd.init.in
4 files changed, 50 insertions(+), 53 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/6991/1
--
To view, visit http://gerrit.ovirt.org/6991
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
11 years, 10 months
Change in vdsm[master]: bootstrap: introduce bootstrap interface version
by Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review.
Change subject: bootstrap: introduce bootstrap interface version
......................................................................
bootstrap: introduce bootstrap interface version
Bootstrap interface version is a method of supporting multiple engine
versions within bootstrap code.
The vdsm-bootstrap code is separate package which can be upgraded
without engine upgrade. Engine is also upgrade protected, so force
update upon vdsm-bootstrap upgrade is difficult.
As the vdsm-bootstrap is separate package from engine, but depends
heavily on engine interaction, and since it may be updated, it should
support backward compatibility with different versions of engines.
If changes are relatively small, a bootstrap interface version may come
in handy so no script duplication is required.
Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M vds_bootstrap/vds_bootstrap.py
M vds_bootstrap/vds_bootstrap_complete.py
M vdsm_reg/deployUtil.py.in
3 files changed, 23 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/7092/1
--
To view, visit http://gerrit.ovirt.org/7092
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 10 months
Change in vdsm[master]: BZ#848843 Enable vdsm hooks on fedora
by Federico Simoncelli
Federico Simoncelli has uploaded a new change for review.
Change subject: BZ#848843 Enable vdsm hooks on fedora
......................................................................
BZ#848843 Enable vdsm hooks on fedora
Change-Id: If2532336b956cb01fd4090fccefd325c3cf2e571
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/7266/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 23afd6b..5224257 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -10,6 +10,10 @@
%global snlk_group @SNLKGROUP@
%global snlk_user @SNLKUSER@
+%if 0%{?fedora}
+%global with_hooks 1
+%endif
+
# Required paths
%global _polkitdir %{_localstatedir}/lib/polkit-1/localauthority/10-vendor.d
--
To view, visit http://gerrit.ovirt.org/7266
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If2532336b956cb01fd4090fccefd325c3cf2e571
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
11 years, 10 months
Change in vdsm[master]: vds_bootstrap: Adding sanlock packages to REQ_PACK
by Douglas Schilling Landgraf
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vds_bootstrap: Adding sanlock packages to REQ_PACK
......................................................................
vds_bootstrap: Adding sanlock packages to REQ_PACK
Adding sanlock and sanlock-python to required packages list.
In case these packages are not available to install do not
show long error message in Engine.
Change-Id: Icb3d61ee217578c4571eab9b65aefcefa300dcb8
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M vds_bootstrap/vds_bootstrap.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/7281/1
diff --git a/vds_bootstrap/vds_bootstrap.py b/vds_bootstrap/vds_bootstrap.py
index 1a8ce8c..152ce47 100755
--- a/vds_bootstrap/vds_bootstrap.py
+++ b/vds_bootstrap/vds_bootstrap.py
@@ -85,7 +85,8 @@
# Required packages
REQ_PACK = ('SDL.x86_64','bridge-utils.x86_64','mesa-libGLU.x86_64',
- 'openssl.x86_64', 'rsync.x86_64')
+ 'openssl.x86_64', 'rsync.x86_64', 'sanlock.x86_64',
+ 'sanlock-python.x86_64')
if rhel6based:
DEVEL_PACK = ()
--
To view, visit http://gerrit.ovirt.org/7281
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb3d61ee217578c4571eab9b65aefcefa300dcb8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
11 years, 10 months
Change in vdsm[master]: Add genisoimage to rpm dependencies
by zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: Add genisoimage to rpm dependencies
......................................................................
Add genisoimage to rpm dependencies
vdsm/mkimage.py is using mkisofs, this command is provided by
genisoimage.
Change-Id: I67d33637982f08e8545a8e5ad8b3fd719ccfec5b
Signed-off-by: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/7232/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 23afd6b..ae03091 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -84,6 +84,7 @@
Requires: tree
Requires: dosfstools
Requires: policycoreutils-python
+Requires: genisoimage
Requires(pre,preun): policycoreutils-python
Requires: libselinux-python
Requires: %{name}-python = %{version}-%{release}
--
To view, visit http://gerrit.ovirt.org/7232
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67d33637982f08e8545a8e5ad8b3fd719ccfec5b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
11 years, 10 months
Change in vdsm[master]: bootstrap: always use /tmp for output files
by Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review.
Change subject: bootstrap: always use /tmp for output files
......................................................................
bootstrap: always use /tmp for output files
Engine sends and collects files from /tmp. /tmp is *ALWAYS* used from
node or from none-node installations.
While bootstrap code uses the following directory:
tempfile.gettempdir()
This is invalid as there is no sync between engine and bootstrap code,
because if TMPDIR environment variable is defined at computer where
bootstrap is running on, files will go to whatever value in TMPDIR
and not /tmp, hence failing the bootstrap process.
This is a BUG in current code, it is not a feature.
This change remove this in favor of plain /tmp usage for files, it
does not imply that the bootstrap scripts are executed at /tmp, only
that the input and output files are stored where engine collects them.
This change is NOT a regression as it work in more scenarios than
current implementation using current engine implementation.
/tmp is mandatory in FHS[1] and in POSIX,p2 systems, all Linux
distributions comply with this.
---
The /tmp directory must be made available for programs that require
temporary files.
Programs must not assume that any files or directories in /tmp are
preserved between invocations of the
program.
---
FUTURE
If the need manifests, engine can ask destination where to place bootstrap
script wither by using environment (TMPDIR, OVIRT_TMPDIR), or by looking
at /etc/ file. Bootstrap script may produce certificate request or any
other output at stdout to allow collection via the ssh session, it also
may get input via stdin during execution, so no file transfer is required
during bootstrap except of bootstrap scripts nor several iterations.
[1] http://www.pathname.com/fhs/
Change-Id: Ia93bcf5b3a911fba985f52391a47caf858697581
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M vdsm_reg/deployUtil.py.in
1 file changed, 1 insertion(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/7091/1
--
To view, visit http://gerrit.ovirt.org/7091
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia93bcf5b3a911fba985f52391a47caf858697581
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 10 months
Change in vdsm[master]: Report host hyperthreads as real cores
by Dan Kenigsberg
Dan Kenigsberg has uploaded a new change for review.
Change subject: Report host hyperthreads as real cores
......................................................................
Report host hyperthreads as real cores
(Only if the customer really wants that)
Vdsm used to report CPU hyperthreads as if they were real CPU cores.
This was fixed in 6df2456b2a1. However, there are people out their who
rely on Vdsm's former behaviour. Let us let them revert to it.
Change-Id: I950c1ce84933204b2d33844c3b3d9485667581af
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/caps.py
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/7097/1
--
To view, visit http://gerrit.ovirt.org/7097
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I950c1ce84933204b2d33844c3b3d9485667581af
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
11 years, 10 months
Change in vdsm[master]: schema: Add doc for setMOMPolicy
by wudxw@linux.vnet.ibm.com
Mark Wu has uploaded a new change for review.
Change subject: schema: Add doc for setMOMPolicy
......................................................................
schema: Add doc for setMOMPolicy
The schema defintion for setMOMPolicy was missing from the patch
which introduced that verb. So add it by this patch.
Change-Id: Ic368f80037c932db3ab0696f94117787e00cacd7
Signed-off-by: Mark Wu <wudxw(a)linux.vnet.ibm.com>
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/7198/1
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 164c0de..13a5bc9 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -435,6 +435,17 @@
'returns': {'allTasksStatus': 'TasksStatus'}}
##
+# @Global.setMOMPolicy:
+#
+# Set MOM policy for different level of overcommitments.
+#
+# @policy: MOM policy string.
+# Since: 4.10.0
+##
+{'command': {'class': 'Global', 'name': 'setMOMPolicy'},
+ 'data': {'policy': 'str'}}
+
+##
# @StringMap:
#
# A mapping between arbitrary strings.
--
To view, visit http://gerrit.ovirt.org/7198
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic368f80037c932db3ab0696f94117787e00cacd7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
11 years, 10 months