Zhou Zheng Sheng has uploaded a new change for review.
Change subject: call sync before umount in mkFloppyFs
......................................................................
call sync before umount in mkFloppyFs
mkFloppyFs creates a floppy image, mount it, write some content, and
umount the image. On some systems, if we umount immediately after writing
content, umount will fail, because the data is not fully synced to disk,
and the device is still busy. This problem causes unit test test_mkFloppyFs
in mkimageTests.py fail.
To avoid the busy device problem, call /usr/bin/sync before umount.
Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Signed-off-by: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
---
M configure.ac
M vdsm/constants.py.in
M vdsm/mkimage.py
M vdsm/storage/misc.py
4 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/6995/1
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Hello Ayal Baron, Timothy Asir, Saggi Mizrahi, Federico Simoncelli, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/6999
to review the following change.
Change subject: Added xml option in gluster command execution.
......................................................................
Added xml option in gluster command execution.
This helps to run gluster command which outputs in xml or standard
format.
Change-Id: I385f992005d446b417be84eb7ff484e4edf6e5b6
Signed-off-by: Bala.FA <barumuga(a)redhat.com>
---
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
2 files changed, 28 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/6999/1
--
To view, visit http://gerrit.ovirt.org/6999
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I385f992005d446b417be84eb7ff484e4edf6e5b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Adam Litke has uploaded a new change for review.
Change subject: schema: Introduce a Test object
......................................................................
schema: Introduce a Test object
Add a Test Class that can be used for testing complex argument and return value
handling. Currently I am envisioning using this for unit tests where we don't
want to connect to a real vdsm server.
Change-Id: I66c7f17f243c92a0cf6260b4f872477413fe6d49
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 51 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/7018/1
--
To view, visit http://gerrit.ovirt.org/7018
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66c7f17f243c92a0cf6260b4f872477413fe6d49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Adam Litke has uploaded a new change for review.
Change subject: schema: Fixup command return values
......................................................................
schema: Fixup command return values
Commands return a single unnamed typed item. Fix the schema to reflect this.
Some vdsm commands return multiple keys in the result dictionary and those keys
need to be combined into a new type representing the complete return value.
Change-Id: Id5e10d4cfeb9734ee0c8d36a7c9c24022e7b3e61
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 167 insertions(+), 149 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/7017/1
--
To view, visit http://gerrit.ovirt.org/7017
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5e10d4cfeb9734ee0c8d36a7c9c24022e7b3e61
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Adam Litke has uploaded a new change for review.
Change subject: schema: Add StorageDomainStatsMap map type
......................................................................
schema: Add StorageDomainStatsMap map type
API.getStorageRepoStats refers to an undefined mapping type. Add it.
Change-Id: I3a0b0fe634b858a4fd8be935be0f02fae8c132b0
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/7014/1
--
To view, visit http://gerrit.ovirt.org/7014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a0b0fe634b858a4fd8be935be0f02fae8c132b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Adam Litke has uploaded a new change for review.
Change subject: schema: Add class constructors to the schema
......................................................................
schema: Add class constructors to the schema
All classes will accept parameters when they are instantiated. Record the
parameters in the schema.
Change-Id: Ifee309b2459da125d351b218accb0f4eff0d78a3
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 61 insertions(+), 35 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/7011/1
--
To view, visit http://gerrit.ovirt.org/7011
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifee309b2459da125d351b218accb0f4eff0d78a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Adam Litke has uploaded a new change for review.
Change subject: schema: Rename Global class to API
......................................................................
schema: Rename Global class to API
The API class is the root of the API. It will have functions to connect and
disconnect from the server. It will also have all of the commands that used to
be defined as 'Global' since it doesn't make sense to sub-class them.
Change-Id: I64afff9e5b5f6c977a3c097b7f903f1b9527df8f
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 43 insertions(+), 43 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/7010/1
--
To view, visit http://gerrit.ovirt.org/7010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64afff9e5b5f6c977a3c097b7f903f1b9527df8f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>