Change in vdsm[master]: Reduce log verbosity for unknown devices from error to warn
by Haim Ateya
Haim Ateya has uploaded a new change for review.
Change subject: Reduce log verbosity for unknown devices from error to warn
......................................................................
Reduce log verbosity for unknown devices from error to warn
Change-Id: I64fc9aa369325d0cb3dfc40e762ab82659083c6d
---
M vdsm/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/2056/1
--
To view, visit http://gerrit.ovirt.org/2056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64fc9aa369325d0cb3dfc40e762ab82659083c6d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya <hateya(a)redhat.com>
12 years, 3 months
Change in vdsm[master]: Make validateStorageServerConnection API call a noop
by smizrahi@redhat.com
Saggi Mizrahi has uploaded a new change for review.
Change subject: Make validateStorageServerConnection API call a noop
......................................................................
Make validateStorageServerConnection API call a noop
This call is useless and slow. It check different things in different
levels for different storage types and does not guarantee a future
connect will succeed. Until someone actually defines what is actually
being validated (params? hostname? permissions? authentication tokens?)
I suggest to just disable this verb so it doesn't make any NFS
connection take twice as long and be exponentially more complex.
Change-Id: Ia56e7bb5b3f725de8f9a8e4498c67ff20b83824b
---
M vdsm/storage/hsm.py
1 file changed, 4 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/1097/1
--
To view, visit http://gerrit.ovirt.org/1097
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia56e7bb5b3f725de8f9a8e4498c67ff20b83824b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 3 months
Change in vdsm[master]: Fix connectStorageServer doc string
by smizrahi@redhat.com
Saggi Mizrahi has uploaded a new change for review.
Change subject: Fix connectStorageServer doc string
......................................................................
Fix connectStorageServer doc string
Change-Id: I505210f61213f2a867446b68094eb046ab6fc952
---
M vdsm/storage/hsm.py
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/1098/1
--
To view, visit http://gerrit.ovirt.org/1098
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I505210f61213f2a867446b68094eb046ab6fc952
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 3 months
Change in vdsm[master]: Fix remotePath comperision in getStorageDomainsList
by smizrahi@redhat.com
Saggi Mizrahi has uploaded a new change for review.
Change subject: Fix remotePath comperision in getStorageDomainsList
......................................................................
Fix remotePath comperision in getStorageDomainsList
Change-Id: I50c856f0a612b27672a5c6ccda877979455b00f5
---
M vdsm/storage/hsm.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/1244/1
--
To view, visit http://gerrit.ovirt.org/1244
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50c856f0a612b27672a5c6ccda877979455b00f5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 3 months
Change in vdsm[master]: add/del network - add bridgesless network
by shavivi@redhat.com
Shahar Havivi has uploaded a new change for review.
Change subject: add/del network - add bridgesless network
......................................................................
add/del network - add bridgesless network
Change-Id: Id7a3efea92312ac628e0373a5c29fbb1669058f4
---
M vdsm/clientIF.py
M vdsm/configNetwork.py
M vdsm/netinfo.py
3 files changed, 123 insertions(+), 58 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/848/1
--
To view, visit http://gerrit.ovirt.org/848
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7a3efea92312ac628e0373a5c29fbb1669058f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
12 years, 3 months
Change in vdsm[master]: BZ790014 Fix multiple issues in detachSD
by Federico Simoncelli
Federico Simoncelli has uploaded a new change for review.
Change subject: BZ790014 Fix multiple issues in detachSD
......................................................................
BZ790014 Fix multiple issues in detachSD
In this patch:
* Remove __unmountLastMaster, the manager cannot deactivate the master
storage domain (where the SPM resource is hold)
* Move all the checks related to the master migration inside masterMigrate
* detachSD cannot be used to migrate a master and it can be used only on
domains that are inactive
Change-Id: I04a7c16df86b828c514daab34f21e352919217f9
---
M vdsm/storage/sp.py
1 file changed, 34 insertions(+), 58 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/76/1876/1
--
To view, visit http://gerrit.ovirt.org/1876
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04a7c16df86b828c514daab34f21e352919217f9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
12 years, 3 months
Change in vdsm[master]: Restore optional drive cap.
by ewarszaw@redhat.com
Eduardo has uploaded a new change for review.
Change subject: Restore optional drive cap.
......................................................................
Restore optional drive cap.
Change-Id: I1582b35c901b9bd146f2f315fbd40278165bd6a3
---
M vdsm/clientIF.py
1 file changed, 8 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/1935/1
--
To view, visit http://gerrit.ovirt.org/1935
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1582b35c901b9bd146f2f315fbd40278165bd6a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
12 years, 3 months
Change in vdsm[master]: Refactor upgrade process to facilitate repository format con...
by abaron@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Refactor upgrade process to facilitate repository format conversions
......................................................................
Patch Set 19: I would prefer that you didn't submit this
(11 inline comments)
....................................................
File vdsm/storage/repositoryConverter.py
Line 3: CFEAT_LIVE_UPGRADE = "live upgrade"
cfeat?
Line 5: def convert_LegacyVersionUpgrade(domain, targetFormat):
why underscore?
Line 9: return (currentFormat, tagetFormat) in CONVERTERS
%s/taget/target/g
Line 16: _getConverter(currentFormat, targetFormat)
why both this and conversionAvailable?
....................................................
File vdsm/storage/sdc.py
Line 39: """ Used so we can change domain objects (convert format) on the fly
s/.*/Keeps domain references valid even when underlying domain object changes (due to format conversion for example)./
Line 46: #FIXME : this objects holding callbacks will not be updated
s/this//
Line 47: # this is currently not needed but fix in case it does
s/does/is/
....................................................
File vdsm/storage/sd.py
Line 143: if version not in (0, 2):
why not SUPPORTED_DOMAIN_FORMATS?
Line 621: def getFormat(self):
why keep 'getVersion'? int/str semantics?
....................................................
File vdsm/storage/sp.py
Line 195: self._convertMemberDomain(domain, targetPoolVersion)
I'm assuming that if "currDomVersion > targetPoolVersion" then there will be no converter available?
Line 415: if not repositoryConverter.canConvert(domainFormat, targetDomainFormat):
why aren't these validations inside repositoryConverter.convert?
--
To view, visit http://gerrit.ovirt.org/193
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b036d244f3cf5b0adda129b44be5cff473dc9b7
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 3 months
Change in vdsm[master]: Extracted image related functinality to another class
by abaron@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Extracted image related functinality to another class
......................................................................
Patch Set 19: Looks good to me, approved
Approving assuming:
1. You made no changes in the code you transferred from sp.py to the new module
2. You will fix the unsecured issue
--
To view, visit http://gerrit.ovirt.org/191
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic29dc8d964f0c2e56329e7044a3b2f48a9f2e193
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 3 months
Change in vdsm[master]: Improve the lvm.USER_DEV_LIST parsing
by Federico Simoncelli
Federico Simoncelli has uploaded a new change for review.
Change subject: Improve the lvm.USER_DEV_LIST parsing
......................................................................
Improve the lvm.USER_DEV_LIST parsing
In this patch:
* Remove the ConfigParser.Error exception handling (impossible)
* Filter out empty strings
Change-Id: I8020b990f1b74b081a46de5e215dc27745466186
---
M vdsm/storage/lvm.py
1 file changed, 2 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/1890/1
--
To view, visit http://gerrit.ovirt.org/1890
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8020b990f1b74b081a46de5e215dc27745466186
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
12 years, 3 months