[NEW PATCH] BZ#726359 Use ethtool to get interface state (via gerrit-bot)
by Federico Simoncelli
New patch submitted by Federico Simoncelli (fsimonce(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/759
commit fcadfb9010a6c91127b02a3014c6e2bc3e8505ec
Author: Federico Simoncelli <fsimonce(a)redhat.com>
Date: Thu Jul 28 13:01:12 2011 +0000
BZ#726359 Use ethtool to get interface state
Change-Id: Ide8773361c3eec26297eae4d413e9d259d2000ec
diff --git a/vdsm/utils.py b/vdsm/utils.py
index 1d3f058..58a5604 100644
--- a/vdsm/utils.py
+++ b/vdsm/utils.py
@@ -120,13 +120,11 @@ class InterfaceSample:
:returns: ``'up'`` if interface is up. ``'down'`` or ``0`` id it's down.
"""
- f = '/sys/class/net/%s/operstate' % (ifid,)
try:
- s = file(f).readline().strip()
- except:
- logging.debug(traceback.format_exc())
+ flags = ethtool.get_flags(ifid)
+ except IOError:
return '0'
- return s
+ return 'up' if flags & ethtool.IFF_UP else 'down'
def __init__(self, ifid):
self.rx = self.readIfaceStat(ifid, 'rx_bytes')
12 years, 9 months
Change in vdsm[master]: BZ#726643 Force VDSM_DIR in sys.path
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#726643 Force VDSM_DIR in sys.path
......................................................................
Patch Set 1: (1 inline comment)
....................................................
Commit Message
Line 7: BZ#726643 Force VDSM_DIR in sys.path
strictly speaking, you should clone this bug to rhel6.
--
To view, visit http://gerrit.usersys.redhat.com/767
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d951b1263bac52c350fe02012a5cfeeef48ba70
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
12 years, 10 months
Change in vdsm[master]: BZ#699976 Bypass host cache when using qemu-img
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#699976 Bypass host cache when using qemu-img
......................................................................
BZ#699976 Bypass host cache when using qemu-img
Change-Id: I8ce999766cec2aa3d9f612c8eb1e796cdcc23ffd
---
M vdsm.spec.in
M vdsm/storage/volume.py
2 files changed, 10 insertions(+), 4 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
David Naori: Verified
--
To view, visit http://gerrit.usersys.redhat.com/756
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ce999766cec2aa3d9f612c8eb1e796cdcc23ffd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com>
12 years, 10 months
[NEW PATCH] BZ#722754 Limit lvm retries to broken devices (via gerrit-bot)
by Federico Simoncelli
New patch submitted by Federico Simoncelli (fsimonce(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/730
commit 9e3483faf360c271027652fcb67273d76bc4146d
Author: Federico Simoncelli <fsimonce(a)redhat.com>
Date: Wed Jul 20 15:27:52 2011 +0000
BZ#722754 Limit lvm retries to broken devices
Change-Id: I74dfdea05943f72c7b89eba42246fc8f26bf0035
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index ef60c02..021dcfc 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -178,6 +178,7 @@ devices {
preferred_names = ["^/dev/mapper/"]
ignore_suspended_devices=1
write_cache_state=0
+disable_after_error_count=3
%s
}
12 years, 10 months
[NEW PATCH] BZ#726045 mask OSError in case domain sampling fails (via gerrit-bot)
by smizrahi@redhat.com
New patch submitted by Saggi Mizrahi (smizrahi(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/754
commit a1b7ee72d7d8649717fefd807386809c067fc632
Author: Saggi Mizrahi <smizrahi(a)redhat.com>
Date: Thu Jul 28 10:14:01 2011 +0300
BZ#726045 mask OSError in case domain sampling fails
Change-Id: Ic7a0bd47f8624a5f74930692b1a21a221e862804
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index 1ddc3db..878ce20 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -91,11 +91,9 @@ class StatsThread(threading.Thread):
def run(self):
while self._statsletrun:
try:
- delay = 0
if self._domain is None:
self._domain = SDF.produce(self._sdUUID)
stats, code = self._statsfunc(self._domain)
- delay = self._domain.getReadDelay()
except se.StorageException, e:
self.log.error("Unexpected error", exc_info=True)
code = e.code
@@ -103,6 +101,15 @@ class StatsThread(threading.Thread):
self.log.error("Unexpected error", exc_info=True)
code = 200
+ delay = 0
+ try:
+ # This is handled seperatly because in case of this kind
+ # of failure we don't want to print stack trace
+ delay = self._domain.getReadDelay()
+ except Exception, e:
+ self.log.error("Could not figure out delay for domain `%s` (%s)", self._sdUUID, e)
+ code = 200
+
if code != 0:
self._domain = None
12 years, 10 months
Change in vdsm[master]: BZ#699976 Bypass host cache when using qemu-img
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#699976 Bypass host cache when using qemu-img
......................................................................
Patch Set 1: Looks good to me, approved
qemu-kvm-0.12.1.2-2.172.el6 is in the hybrid repo, so this can go in.
--
To view, visit http://gerrit.usersys.redhat.com/756
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ce999766cec2aa3d9f612c8eb1e796cdcc23ffd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
12 years, 10 months