Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#745390 always report product=RHEV to guest bios
......................................................................
BZ#745390 always report product=RHEV to guest bios
Two years after insisting the ueber-importance of differentiating RHEL
hosts from RHEV ones, RHN/Satellite suddenly needs us to always report
"RHEV-H" to the guest, or else the guest would not be recognized as
virtual by them.
Disagreing and committing.
Change-Id: Ibcee345c6960ffb35f517a7dd77d5919c4101afa
---
M vdsm/libvirtvm.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1039
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcee345c6960ffb35f517a7dd77d5919c4101afa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#745390 always report product=RHEV to guest bios
......................................................................
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1039
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcee345c6960ffb35f517a7dd77d5919c4101afa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#746766 deployUtil: set proper selinux context to .ssh/authorized_hosts
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm_reg/deployUtil.py.in
Line 558: if fReturn:
Line 559: try:
Line 560: os.chmod(P_ROOT_AUTH_KEYS, 0644)
Line 561: selinux.restorecon(P_ROOT_AUTH_KEYS)
Line 562: except:
doh, I shouldn't have asked YOU for a review. ;-)
All you say is correct, but is relater to a bigger scope of having a sane deployUtil module. This patch must not have any behavioral change, save for the requested one. and currently we perform the sin of catching all exceptions. gahh.
Line 563: fReturn = False
Line 564: logging.debug("handleSSHKey: failed to chmod authorized_keys",
Line 565: exc_info=True)
Line 566:
--
To view, visit http://gerrit.usersys.redhat.com/1045
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6833b991f89033b0b6ab0c85fb6f8df49809ea26
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Eduardo Warszawski has posted comments on this change.
Change subject: BZ#746766 deployUtil: set proper selinux context to .ssh/authorized_hosts
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm_reg/deployUtil.py.in
Line 558: if fReturn:
Line 559: try:
Line 560: os.chmod(P_ROOT_AUTH_KEYS, 0644)
Line 561: selinux.restorecon(P_ROOT_AUTH_KEYS)
Line 562: except:
except OSError: and change the logic for fReturn=True only on success.
restorecon() can fail.
Line 563: fReturn = False
Line 564: logging.debug("handleSSHKey: failed to chmod authorized_keys",
Line 565: exc_info=True)
Line 566:
Line 566:
Line 567: if fReturn and isOvirt():
Line 568: # persist authorized_keys
Line 569: logging.debug("handleSSHKey: persist authorized_keys")
Line 570: ovirtfunctions.ovirt_store_config(P_ROOT_AUTH_KEYS)
Can fail?
Line 571:
Line 572: logging.debug('handleSSHKey end')
Line 573: return fReturn
Line 574:
--
To view, visit http://gerrit.usersys.redhat.com/1045
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6833b991f89033b0b6ab0c85fb6f8df49809ea26
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Yaniv Kaul has posted comments on this change.
Change subject: BZ#746766 restorecon whenever file access matters
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 205: shutil.copy2(filename, backup)
Line 206: else:
Line 207: open(backup, 'w').write(cls.DELETED_HEADER + '\n')
Line 208: os.chown(backup, vdsm_uid, 0)
Line 209: selinux(backup)
Should be selinux.restorecon() ?
Line 210: logging.debug("Persistently backed up %s (until next 'set safe config')" % filename)
Line 211:
Line 212: def addBridge(self, name, ipaddr=None, netmask=None, gateway=None,
Line 213: bootproto=None, delay='0', onboot='yes', **kwargs):
--
To view, visit http://gerrit.usersys.redhat.com/1046
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I86e24f29e784a35a4497b94dc8a3bbba673160c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#746975 - Allow deactivate storage domain if not reachable
......................................................................
BZ#746975 - Allow deactivate storage domain if not reachable
Change-Id: Id547f6bdb1a8e5c41340981c9453a98d099d713e
---
M vdsm/storage/sp.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Igor Lvovsky: Verified
--
To view, visit http://gerrit.usersys.redhat.com/1044
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id547f6bdb1a8e5c41340981c9453a98d099d713e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has posted comments on this change.
Change subject: BZ#741203 Don't return a value in domain selftest
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1012
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I551970c1f426f2b28ad58e49310338de6b40a29f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Igor Lvovsky has posted comments on this change.
Change subject: BZ#745390 always report product=RHEV to guest bios
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1039
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcee345c6960ffb35f517a7dd77d5919c4101afa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>