Change in vdsm[master]: Add the systemd support for bootstrap
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Add the systemd support for bootstrap
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1043
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I118256a15ddf442dc96168ab04db5b89627c83e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
12 years, 8 months
Change in vdsm[master]: Convert the OrderedDict from namedtuple._asdict()
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Convert the OrderedDict from namedtuple._asdict()
......................................................................
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1029
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5582f77fbfc6961dcada3f733cb9353dee53cf53
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 8 months
Change in vdsm[master]: Recreate the run paths when needed
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Recreate the run paths when needed
......................................................................
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1030
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6eee71ce11e47a64bf825089445d6ef4ec504d82
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 8 months
Change in vdsm[master]: [WIP] RPM changes for Fedora
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: [WIP] RPM changes for Fedora
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1023
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cc880f8579b254f49981d88f4045ac124559458
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
12 years, 8 months
Change in vdsm[master]: Add libvirt password as config file
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Add libvirt password as config file
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/libvirt_password
Line -3
Line -2
Line -1
Line 0
Line 1: shibboleth
this has newline, which means a changed password.
Line 2
Line 3
Line 4
Line 5
....................................................
File vdsm.spec.in
Line 135: rm -f /etc/init/libvirtd.conf
Line 136:
Line 137: /sbin/chkconfig libvirtd on
Line 138: /sbin/service libvirtd start >/dev/null
Line 139: fi
it would be nicer to delete the saslpasswd here.
Line 140: fi
Line 141:
Line 142: %postun
Line 143: if [ "$1" -ge 1 ]; then
--
To view, visit http://gerrit.usersys.redhat.com/1052
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23d2ac1f9d558840dd0ac511db5bde0bac32c2b5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years, 8 months
Change in vdsm[master]: BZ#725540 vdsClient: check return code first
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#725540 vdsClient: check return code first
......................................................................
BZ#725540 vdsClient: check return code first
client should not assume that its data exists in the response before verifying
that the request was served without error.
Change-Id: Iffa0c0eb6b50b321f97a578994d7cf48bdae2974
---
M vdsm_cli/vdsClient.py
1 file changed, 12 insertions(+), 2 deletions(-)
Approvals:
Dan Kenigsberg: Verified
Igor Lvovsky: Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1031
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iffa0c0eb6b50b321f97a578994d7cf48bdae2974
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years, 8 months
Change in vdsm[master]: BZ#725540 vdsClient: check return code first
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#725540 vdsClient: check return code first
......................................................................
Patch Set 1: Verified
(1 inline comment)
....................................................
Commit Message
Line 3: AuthorDate: 2011-10-13 23:09:35 +0200
Line 4: Commit: Dan Kenigsberg <danken(a)redhat.com>
Line 5: CommitDate: 2011-10-13 23:21:29 +0200
Line 6:
Line 7: BZ#725540 vdsClient: check return code first
that bz mentioned one case of unchecked code value. I've fixed other occasions, too.
Line 8:
Line 9: client should not assume that its data exists in the response before verifying
Line 10: that the request was served without error.
Line 11:
--
To view, visit http://gerrit.usersys.redhat.com/1031
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffa0c0eb6b50b321f97a578994d7cf48bdae2974
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years, 8 months
Change in vdsm[master]: Move iscsid.conf template outside of the source file
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Move iscsid.conf template outside of the source file
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm.spec.in
Line 294: %{_datadir}/%{vdsm_name}/storage/resourceFactories.py*
Line 295: %{_datadir}/%{vdsm_name}/storage/outOfProcess.py*
Line 296: %{_datadir}/%{vdsm_name}/storage/processPool.py*
Line 297: %{_datadir}/%{vdsm_name}/storage/iscsi.py*
Line 298: %{_datadir}/%{vdsm_name}/storage/iscsid.conf.template*
no need in final astrisk
Line 299: %{_datadir}/%{vdsm_name}/storage/devicemapper.py*
Line 300: %{_datadir}/%{vdsm_name}/storage/securable.py*
Line 301: %{_datadir}/%{vdsm_name}/storage/multipath.py*
Line 302: %{_datadir}/%{vdsm_name}/storage/sdc.py*
....................................................
File vdsm/storage/Makefile.am
Line 48: securable.py
Line 49:
Line 50: EXTRA_DIST = \
Line 51: 12-vdsm-lvm.rules
Line 52: iscsid.conf.template
that's not enough - you should actually install it somewhere.
Line 53:
Line 54: check-local:
Line 55: python $(srcdir)/storage_exception.py
Line 56:
--
To view, visit http://gerrit.usersys.redhat.com/1034
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59ab2a951ddf15941218524ad7eb5bf94295023e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 8 months
Change in vdsm[master]: Fix bad rebase
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix bad rebase
......................................................................
Fix bad rebase
Change-Id: Icaad8cd5214d78d0265b743c5f70d57d17be990a
---
M vdsm/storage/hsm.py
1 file changed, 5 insertions(+), 6 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1058
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icaad8cd5214d78d0265b743c5f70d57d17be990a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
12 years, 8 months