Saggi Mizrahi has uploaded a new change for review.
Change subject: Remove support for string command ......................................................................
Remove support for string command
Without the shell arg it's useless anyway as the command will fail anyway.
Change-Id: I41cf646e88ad0b4459cf2a3c4515c75d6992f26b Signed-off-by: Saggi Mizrahi smizrahi@redhat.com --- M vdsm/storage/misc.py 1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/3943/1 -- To view, visit http://gerrit.ovirt.org/3943 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I41cf646e88ad0b4459cf2a3c4515c75d6992f26b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Remove support for string command ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3943 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I41cf646e88ad0b4459cf2a3c4515c75d6992f26b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Remove support for string command ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3943 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I41cf646e88ad0b4459cf2a3c4515c75d6992f26b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Remove support for string command ......................................................................
Patch Set 6: Verified; Looks good to me, approved
I hate shell parsing anyway.
-- To view, visit http://gerrit.ovirt.org/3943 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I41cf646e88ad0b4459cf2a3c4515c75d6992f26b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove support for string command ......................................................................
Remove support for string command
Without the shell arg it's useless anyway as the command will fail anyway.
Change-Id: I41cf646e88ad0b4459cf2a3c4515c75d6992f26b Signed-off-by: Saggi Mizrahi smizrahi@redhat.com --- M vdsm/storage/misc.py 1 file changed, 1 insertion(+), 5 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3943 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I41cf646e88ad0b4459cf2a3c4515c75d6992f26b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org