Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: replace bridge name from brVDSM to engine ......................................................................
replace bridge name from brVDSM to engine
Change-Id: I8115192b65b431e8066313bda357f8aa86880c86 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/772/1 -- To view, visit http://gerrit.ovirt.org/772 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I8115192b65b431e8066313bda357f8aa86880c86 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: replace bridge name from brVDSM to engine ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
It is either this, or ovirt-engine changing their management network name. I cannot take this after an explicit NACK by Ayal, and I cannot force Doron to take brVDSM. Please help.
-- To view, visit http://gerrit.ovirt.org/772 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8115192b65b431e8066313bda357f8aa86880c86 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com
Doron Fediuck has posted comments on this change.
Change subject: replace bridge name from brVDSM to engine ......................................................................
Patch Set 1: Verified; Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File configure.ac Line 63: AC_SUBST([vdsmbridge], ['engine']) Is this replacing brVDSM with engine?
I have no problem with it, but if Ayal wishes to, you may choose a more meaningful name such as "mgmt-net" or any similar name.
Giving this my ack, but feel free to come up with something else.
-- To view, visit http://gerrit.ovirt.org/772 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8115192b65b431e8066313bda357f8aa86880c86 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com
Ayal Baron has posted comments on this change.
Change subject: replace bridge name from brVDSM to engine ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File configure.ac Line 63: AC_SUBST([vdsmbridge], ['engine']) Thanks Doron. Indeed, 'engine' is still meaningless. Please change it to something else.
-- To view, visit http://gerrit.ovirt.org/772 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8115192b65b431e8066313bda357f8aa86880c86 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: replace bridge name from brVDSM to engine ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File configure.ac Line 63: AC_SUBST([vdsmbridge], ['engine']) Doron, can we get a universal agreement on ovirtmgmt?
-- To view, visit http://gerrit.ovirt.org/772 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8115192b65b431e8066313bda357f8aa86880c86 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com
Doron Fediuck has posted comments on this change.
Change subject: replace bridge name from brVDSM to engine ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File configure.ac Line 63: AC_SUBST([vdsmbridge], ['engine']) Sure.
Please upload a new patch and I'll ack it (as well).
-- To view, visit http://gerrit.ovirt.org/772 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8115192b65b431e8066313bda357f8aa86880c86 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com
Doron Fediuck has posted comments on this change.
Change subject: replace default bridge name from brVDSM to ovirtmgmt ......................................................................
Patch Set 2: Verified; Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/772 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8115192b65b431e8066313bda357f8aa86880c86 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: replace default bridge name from brVDSM to ovirtmgmt ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/772 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8115192b65b431e8066313bda357f8aa86880c86 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: replace default bridge name from brVDSM to ovirtmgmt ......................................................................
replace default bridge name from brVDSM to ovirtmgmt
Change-Id: I8115192b65b431e8066313bda357f8aa86880c86 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Doron Fediuck: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/772 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I8115192b65b431e8066313bda357f8aa86880c86 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
vdsm-patches@lists.fedorahosted.org