From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: devices: graphics: add from_xml_tree ......................................................................
Patch Set 37:
(2 comments)
minor comment, but generally you have my blessing.
https://gerrit.ovirt.org/#/c/73261/37/lib/vdsm/virt/vmdevices/graphics.py File lib/vdsm/virt/vmdevices/graphics.py:
PS37, Line 178: self.specParams['displayNetwork']) this should have been display_network, no need to __getitem__ twice.
PS37, Line 292: if dev.attrib.get('listen') == '0': : specParams['displayIp'] = '0' I'm not sure we should prefer this deprecated libvirt attrib. Actually, I think we should drop these two lines, as we would explode on find_first('listen') if the new prefereed listen element does not exist.
vdsm-patches@lists.fedorahosted.org