Adam Litke has uploaded a new change for review.
Change subject: schema: Fix up VmDefinition types ......................................................................
schema: Fix up VmDefinition types
There is no such thing as a VmShort definition so we do not need the union type for VmDefinition. Also, VmDefinition is the same as VmStatus so just define the definition as an alias of VmFullStatus.
Change-Id: Iecb73a3ca21908ca3bcb51a3d2c51319291296d9 Signed-off-by: Adam Litke agl@us.ibm.com --- M vdsm_api/vdsmapi-schema.json 1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/7015/1 -- To view, visit http://gerrit.ovirt.org/7015 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Iecb73a3ca21908ca3bcb51a3d2c51319291296d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Fix up VmDefinition types ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/12/
-- To view, visit http://gerrit.ovirt.org/7015 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iecb73a3ca21908ca3bcb51a3d2c51319291296d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Fix up VmDefinition types ......................................................................
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/12/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/7015 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iecb73a3ca21908ca3bcb51a3d2c51319291296d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Fix up VmDefinition types ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/289/
-- To view, visit http://gerrit.ovirt.org/7015 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iecb73a3ca21908ca3bcb51a3d2c51319291296d9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Fix up VmDefinition types ......................................................................
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/289/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/7015 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iecb73a3ca21908ca3bcb51a3d2c51319291296d9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Fix up VmDefinition types ......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/301/
-- To view, visit http://gerrit.ovirt.org/7015 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iecb73a3ca21908ca3bcb51a3d2c51319291296d9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Fix up VmDefinition types ......................................................................
Patch Set 3: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/301/ : ABORTED
-- To view, visit http://gerrit.ovirt.org/7015 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iecb73a3ca21908ca3bcb51a3d2c51319291296d9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Adam Litke has posted comments on this change.
Change subject: schema: Fix up VmDefinition types ......................................................................
Patch Set 3: Verified
-- To view, visit http://gerrit.ovirt.org/7015 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iecb73a3ca21908ca3bcb51a3d2c51319291296d9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Fix up VmDefinition types ......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/329/
-- To view, visit http://gerrit.ovirt.org/7015 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iecb73a3ca21908ca3bcb51a3d2c51319291296d9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Fix up VmDefinition types ......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/329/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7015 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iecb73a3ca21908ca3bcb51a3d2c51319291296d9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Saggi Mizrahi has posted comments on this change.
Change subject: schema: Fix up VmDefinition types ......................................................................
Patch Set 4: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7015 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iecb73a3ca21908ca3bcb51a3d2c51319291296d9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Saggi Mizrahi has submitted this change and it was merged.
Change subject: schema: Fix up VmDefinition types ......................................................................
schema: Fix up VmDefinition types
There is no such thing as a VmShort definition so we do not need the union type for VmDefinition. Also, VmDefinition is the same as VmStatus so just define the definition as an alias of VmFullStatus.
Change-Id: Iecb73a3ca21908ca3bcb51a3d2c51319291296d9 Signed-off-by: Adam Litke agl@us.ibm.com --- M vdsm_api/vdsmapi-schema.json 1 file changed, 12 insertions(+), 12 deletions(-)
Approvals: Saggi Mizrahi: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7015 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Iecb73a3ca21908ca3bcb51a3d2c51319291296d9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org