Hello Ayal Baron, Timothy Asir, Saggi Mizrahi, Federico Simoncelli, Dan Kenigsberg,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: glusterHostsList returns host info as list of dictionaries ......................................................................
glusterHostsList returns host info as list of dictionaries
{'status': {'code': CODE, 'message': MESSAGE}, 'hosts' : [{'hostname': HOSTNAME, 'uuid': UUID, 'status': STATE}, ...]}
Change-Id: Ia05d59020bd4019dab2020988dc621d026b805b6 Signed-off-by: Bala.FA barumuga@redhat.com --- M tests/gluster_cli_tests.py M vdsm/gluster/api.py M vdsm/gluster/cli.py 3 files changed, 19 insertions(+), 23 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/6614/1 -- To view, visit http://gerrit.ovirt.org/6614 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ia05d59020bd4019dab2020988dc621d026b805b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Bala.FA has posted comments on this change.
Change subject: glusterHostsList returns host info as list of dictionaries ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/6614 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia05d59020bd4019dab2020988dc621d026b805b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: glusterHostsList returns host info as list of dictionaries ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... Commit Message Line 7: glusterHostsList returns host info as list of dictionaries if I am not mistaken, you are now changing the API in a non-backward compatible fashion.
If so, please state that clearly in the commit message, and explain why this is acceptable.
-- To view, visit http://gerrit.ovirt.org/6614 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia05d59020bd4019dab2020988dc621d026b805b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Bala.FA has posted comments on this change.
Change subject: glusterHostsList returns host info as list of dictionaries ......................................................................
Patch Set 1: (1 inline comment)
.................................................... Commit Message Line 7: glusterHostsList returns host info as list of dictionaries This API is not consumed by engine/RHS-C yet. Its ok to differ in compatibility issue of this API now. We are sure to have backward compatible APIs in future. Let me know to add this note in commit log.
-- To view, visit http://gerrit.ovirt.org/6614 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia05d59020bd4019dab2020988dc621d026b805b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: glusterHostsList returns host info as list of dictionaries ......................................................................
Patch Set 1: (1 inline comment)
.................................................... Commit Message Line 7: glusterHostsList returns host info as list of dictionaries Yes, move it in the commit message.
-- To view, visit http://gerrit.ovirt.org/6614 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia05d59020bd4019dab2020988dc621d026b805b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Bala.FA has posted comments on this change.
Change subject: glusterHostsList returns host info as list of dictionaries ......................................................................
Patch Set 1: (1 inline comment)
.................................................... Commit Message Line 7: glusterHostsList returns host info as list of dictionaries Done
-- To view, visit http://gerrit.ovirt.org/6614 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia05d59020bd4019dab2020988dc621d026b805b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Bala.FA has posted comments on this change.
Change subject: glusterHostsList returns host info as list of dictionaries ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/6614 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia05d59020bd4019dab2020988dc621d026b805b6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: glusterHostsList returns host info as list of dictionaries ......................................................................
Patch Set 2: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/58/
-- To view, visit http://gerrit.ovirt.org/6614 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia05d59020bd4019dab2020988dc621d026b805b6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: glusterHostsList returns host info as list of dictionaries ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/58/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6614 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia05d59020bd4019dab2020988dc621d026b805b6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Timothy Asir has posted comments on this change.
Change subject: glusterHostsList returns host info as list of dictionaries ......................................................................
Patch Set 2: Verified; Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6614 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia05d59020bd4019dab2020988dc621d026b805b6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: glusterHostsList returns host info as list of dictionaries ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6614 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia05d59020bd4019dab2020988dc621d026b805b6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: glusterHostsList returns host info as list of dictionaries ......................................................................
glusterHostsList returns host info as list of dictionaries
Return value looks like {'status': {'code': CODE, 'message': MESSAGE}, 'hosts' : [{'hostname': HOSTNAME, 'uuid': UUID, 'status': STATE}, ...]}
As this API is not consumed by engine/RHS-C yet, its OK to differ in compatibility issue now.
Change-Id: Ia05d59020bd4019dab2020988dc621d026b805b6 Signed-off-by: Bala.FA barumuga@redhat.com --- M tests/gluster_cli_tests.py M vdsm/gluster/api.py M vdsm/gluster/cli.py 3 files changed, 19 insertions(+), 23 deletions(-)
Approvals: Timothy Asir: Verified; Looks good to me, but someone else must approve Bala.FA: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6614 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ia05d59020bd4019dab2020988dc621d026b805b6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org