Hello Nir Soffer, Yaniv Bronhaim, Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: tool: Remove pointless __init__ methods ......................................................................
tool: Remove pointless __init__ methods
Some configurators had pointless __init__ methods. There is not need to implement these if they are empty. Keeping them only cause developers to copy and paste this useless code when they create new configurators.
Change-Id: I0885600fd8a2257d7d7a3ebe563bf6ee4ca9bb96 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1132677 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: http://gerrit.ovirt.org/31740 Reviewed-by: mooli tayer mtayer@redhat.com Reviewed-by: Francesco Romani fromani@redhat.com Reviewed-by: Yaniv Bronhaim ybronhei@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M lib/vdsm/tool/configurators/__init__.py M lib/vdsm/tool/configurators/sanlock.py 2 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/32060/1
diff --git a/lib/vdsm/tool/configurators/__init__.py b/lib/vdsm/tool/configurators/__init__.py index 219d119..49071ff 100644 --- a/lib/vdsm/tool/configurators/__init__.py +++ b/lib/vdsm/tool/configurators/__init__.py @@ -44,9 +44,6 @@
class ModuleConfigure(object):
- def __init__(self): - pass - def getName(self): return None
diff --git a/lib/vdsm/tool/configurators/sanlock.py b/lib/vdsm/tool/configurators/sanlock.py index 566c5e5..9225252 100644 --- a/lib/vdsm/tool/configurators/sanlock.py +++ b/lib/vdsm/tool/configurators/sanlock.py @@ -36,9 +36,6 @@
SANLOCK_GROUPS = (constants.QEMU_PROCESS_GROUP, constants.VDSM_GROUP)
- def __init__(self): - super(Sanlock, self).__init__() - def getName(self): return 'sanlock'
Francesco Romani has posted comments on this change.
Change subject: tool: Remove pointless __init__ methods ......................................................................
Patch Set 1: Code-Review+1
Nir Soffer has posted comments on this change.
Change subject: tool: Remove pointless __init__ methods ......................................................................
Patch Set 1:
Why do we need this in 3.5?
Nir Soffer has posted comments on this change.
Change subject: tool: Remove pointless __init__ methods ......................................................................
Patch Set 2: Code-Review-1
I don't think we need this in 3.5 - it does not fix any bug and is no other patch depends on it.
mooli tayer has posted comments on this change.
Change subject: tool: Remove pointless __init__ methods ......................................................................
Patch Set 2:
Iv'e also asked yaniv to review this topic and give his feedback on 3.5
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: Remove pointless __init__ methods ......................................................................
Patch Set 2: Code-Review+2
don't see any problem with taking that.
Nir Soffer has posted comments on this change.
Change subject: tool: Remove pointless __init__ methods ......................................................................
Patch Set 2: -Code-Review
mooli tayer has posted comments on this change.
Change subject: tool: Remove pointless __init__ methods ......................................................................
Patch Set 2: Verified+1
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: tool: Remove pointless __init__ methods ......................................................................
tool: Remove pointless __init__ methods
Some configurators had pointless __init__ methods. There is not need to implement these if they are empty. Keeping them only cause developers to copy and paste this useless code when they create new configurators.
Change-Id: I0885600fd8a2257d7d7a3ebe563bf6ee4ca9bb96 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: http://gerrit.ovirt.org/31740 Reviewed-by: mooli tayer mtayer@redhat.com Reviewed-by: Francesco Romani fromani@redhat.com Reviewed-by: Yaniv Bronhaim ybronhei@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com Reviewed-on: http://gerrit.ovirt.org/32060 Tested-by: mooli tayer mtayer@redhat.com --- M lib/vdsm/tool/configurators/__init__.py M lib/vdsm/tool/configurators/sanlock.py 2 files changed, 0 insertions(+), 6 deletions(-)
Approvals: Yaniv Bronhaim: Looks good to me, approved mooli tayer: Verified
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Remove pointless __init__ methods ......................................................................
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/118/ : FAILURE
vdsm-patches@lists.fedorahosted.org