Hello Ayal Baron, Timothy Asir, Saggi Mizrahi, Federico Simoncelli, Dan Kenigsberg,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: glusterVolumesList list all volumes or specified volume. ......................................................................
glusterVolumesList list all volumes or specified volume.
glusterVolumesList accepts volume name optionally to list specified volume only else lists all volumes.
Change-Id: I5be71b1638f74f3d49051673cdbe07361b404465 Signed-off-by: Bala.FA barumuga@redhat.com --- M vdsm/gluster/api.py M vdsm/gluster/cli.py M vdsm_cli/vdsClientGluster.py 3 files changed, 15 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/4916/1 -- To view, visit http://gerrit.ovirt.org/4916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I5be71b1638f74f3d49051673cdbe07361b404465 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Vijay Bellur has posted comments on this change.
Change subject: glusterVolumesList list all volumes or specified volume. ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm_cli/vdsClientGluster.py Line 216: 'all gluster volumes' Shouldn't this be "else all"?
-- To view, visit http://gerrit.ovirt.org/4916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5be71b1638f74f3d49051673cdbe07361b404465 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Vijay Bellur vbellur@gmail.com
Timothy Asir has posted comments on this change.
Change subject: glusterVolumesList list all volumes or specified volume. ......................................................................
Patch Set 2: Verified; Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5be71b1638f74f3d49051673cdbe07361b404465 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Vijay Bellur vbellur@gmail.com
Vijay Bellur has posted comments on this change.
Change subject: glusterVolumesList list all volumes or specified volume. ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5be71b1638f74f3d49051673cdbe07361b404465 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Vijay Bellur vbellur@gmail.com
Dan Kenigsberg has posted comments on this change.
Change subject: glusterVolumesList list all volumes or specified volume. ......................................................................
Patch Set 2: (1 inline comment)
no biggy
.................................................... File vdsm/gluster/cli.py Line 158: command = _getGlusterVolCmd() + ["info"] it could have been cleaner with
command = _getGlusterVolCmd() + ["info"] if volumeName: command.append(volumeName)
-- To view, visit http://gerrit.ovirt.org/4916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5be71b1638f74f3d49051673cdbe07361b404465 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Vijay Bellur vbellur@gmail.com
Bala.FA has posted comments on this change.
Change subject: glusterVolumesList list all volumes or specified volume. ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vdsm/gluster/cli.py Line 158: command = _getGlusterVolCmd() + ["info"] Done
-- To view, visit http://gerrit.ovirt.org/4916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5be71b1638f74f3d49051673cdbe07361b404465 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Vijay Bellur vbellur@gmail.com
Dan Kenigsberg has posted comments on this change.
Change subject: glusterVolumesList list all volumes or specified volume. ......................................................................
Patch Set 3: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5be71b1638f74f3d49051673cdbe07361b404465 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Vijay Bellur vbellur@gmail.com
Dan Kenigsberg has posted comments on this change.
Change subject: glusterVolumesList list all volumes or specified volume. ......................................................................
Patch Set 3: Verified
copying Timothy's V+1.
-- To view, visit http://gerrit.ovirt.org/4916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5be71b1638f74f3d49051673cdbe07361b404465 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Vijay Bellur vbellur@gmail.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: glusterVolumesList list all volumes or specified volume. ......................................................................
glusterVolumesList list all volumes or specified volume.
glusterVolumesList accepts volume name optionally to list specified volume only else lists all volumes.
Change-Id: I5be71b1638f74f3d49051673cdbe07361b404465 Signed-off-by: Bala.FA barumuga@redhat.com --- M vdsm/gluster/api.py M vdsm/gluster/cli.py M vdsm_cli/vdsClientGluster.py 3 files changed, 13 insertions(+), 7 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I5be71b1638f74f3d49051673cdbe07361b404465 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Vijay Bellur vbellur@gmail.com
vdsm-patches@lists.fedorahosted.org