ShaoHe Feng has uploaded a new change for review.
Change subject: change the code style of volume.py for PEP8 compliance ......................................................................
change the code style of volume.py for PEP8 compliance
Change-Id: Ie2397bec4d4035a151c9c7a9bb02f73079adb070 Signed-off-by: ShaoHe Feng shaohef@linux.vnet.ibm.com --- M vdsm/storage/volume.py 1 file changed, 129 insertions(+), 76 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/4496/1 -- To view, visit http://gerrit.ovirt.org/4496 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ie2397bec4d4035a151c9c7a9bb02f73079adb070 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com
Saggi Mizrahi has posted comments on this change.
Change subject: change the code style of volume.py for PEP8 compliance ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4496 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie2397bec4d4035a151c9c7a9bb02f73079adb070 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: change the code style of volume.py for PEP8 compliance ......................................................................
Patch Set 3: (1 inline comment)
I think there is a minor problem. Please refer to the comment on line 18 in volume.py.
.................................................... File vdsm/storage/volume.py Line 18 Why delete '#' in line 17? I think we should keep it.
-- To view, visit http://gerrit.ovirt.org/4496 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie2397bec4d4035a151c9c7a9bb02f73079adb070 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: change the code style of volume.py for PEP8 compliance ......................................................................
Patch Set 4: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4496 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie2397bec4d4035a151c9c7a9bb02f73079adb070 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
ShaoHe Feng has abandoned this change.
Change subject: change the code style of volume.py for PEP8 compliance ......................................................................
Patch Set 4: Abandoned
it was merged in pep8cleaning branch.
-- To view, visit http://gerrit.ovirt.org/4496 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: Ie2397bec4d4035a151c9c7a9bb02f73079adb070 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org