Federico Simoncelli has uploaded a new change for review.
Change subject: Check the metadata on domain validation ......................................................................
Check the metadata on domain validation
When VDSM is validating a storage domain is not checking the presence of the metadata (eg: a domain could result valid even with a missing or empty metadata). This patch introduces an additional check to make sure that the metadata is not empty.
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: I35071b85da2689cd576e9fd0d97cc374db26bf5c --- M vdsm/storage/blockSD.py M vdsm/storage/fileSD.py 2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/7085/1 -- To view, visit http://gerrit.ovirt.org/7085 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I35071b85da2689cd576e9fd0d97cc374db26bf5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Check the metadata on domain validation ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/storage/blockSD.py Line 725: if not len(self.getMetadata()): We could actually try to push this validation inside the metadata providers (raise if the metadata is missing/empty). In such case we must check all the flows since there might be a situation where we rely on the empty metadata (eg: when we select the meta provider for the block domains, etc...).
-- To view, visit http://gerrit.ovirt.org/7085 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I35071b85da2689cd576e9fd0d97cc374db26bf5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Check the metadata on domain validation ......................................................................
Patch Set 1: Looks good to me, approved
Note that BZ# should be in commit message when merging.
Bug 847328 - VDSM domain validation should check the presence of the metadata
-- To view, visit http://gerrit.ovirt.org/7085 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I35071b85da2689cd576e9fd0d97cc374db26bf5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Check the metadata on domain validation ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/patch_vdms_manager/5/
-- To view, visit http://gerrit.ovirt.org/7085 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I35071b85da2689cd576e9fd0d97cc374db26bf5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Check the metadata on domain validation ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdms_manager/5/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7085 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I35071b85da2689cd576e9fd0d97cc374db26bf5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Check the metadata on domain validation ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/patch_vdms_manager/6/
-- To view, visit http://gerrit.ovirt.org/7085 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I35071b85da2689cd576e9fd0d97cc374db26bf5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Check the metadata on domain validation ......................................................................
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.info/job/patch_vdms_manager/6/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/7085 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I35071b85da2689cd576e9fd0d97cc374db26bf5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Check the metadata on domain validation ......................................................................
Patch Set 1: No score
Build Started http://jenkins.ovirt.info/job/patch_vdms_manager/7/
-- To view, visit http://gerrit.ovirt.org/7085 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I35071b85da2689cd576e9fd0d97cc374db26bf5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Check the metadata on domain validation ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdms_manager/7/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7085 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I35071b85da2689cd576e9fd0d97cc374db26bf5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Federico Simoncelli has posted comments on this change.
Change subject: Check the metadata on domain validation ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/7085 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I35071b85da2689cd576e9fd0d97cc374db26bf5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Check the metadata on domain validation ......................................................................
Patch Set 1: I would prefer that you didn't submit this
could you tell why we should find it at validation time?
and why AccessError is a reasonable error (I would expect it in for EPERM or something)
-- To view, visit http://gerrit.ovirt.org/7085 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I35071b85da2689cd576e9fd0d97cc374db26bf5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Check the metadata on domain validation ......................................................................
Check the metadata on domain validation
When VDSM is validating a storage domain is not checking the presence of the metadata (eg: a domain could result valid even with a missing or empty metadata). This patch introduces an additional check to make sure that the metadata is not empty.
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: I35071b85da2689cd576e9fd0d97cc374db26bf5c --- M vdsm/storage/blockSD.py M vdsm/storage/fileSD.py 2 files changed, 4 insertions(+), 2 deletions(-)
Approvals: Ayal Baron: Looks good to me, approved Federico Simoncelli: Verified Dan Kenigsberg:
-- To view, visit http://gerrit.ovirt.org/7085 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I35071b85da2689cd576e9fd0d97cc374db26bf5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Check the metadata on domain validation ......................................................................
Patch Set 1:
This patch tries to solve https://bugzilla.redhat.com/show_bug.cgi?id=847284 - fail domain validation if storage server is not even connected.
-- To view, visit http://gerrit.ovirt.org/7085 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I35071b85da2689cd576e9fd0d97cc374db26bf5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org