Igor Lvovsky has uploaded a new change for review.
Change subject: clientIF: remove network backups at the end of _syncLibvirtNetworks ......................................................................
clientIF: remove network backups at the end of _syncLibvirtNetworks
Change-Id: I8b8f992efa10b6846012a1a8295ee7833d485762 Signed-off-by: Igor Lvovsky ilvovsky@redhat.com --- M vdsm/clientIF.py 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/7063/1 -- To view, visit http://gerrit.ovirt.org/7063 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I8b8f992efa10b6846012a1a8295ee7833d485762 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: remove network backups at the end of _syncLibvirtNetworks ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/278/
-- To view, visit http://gerrit.ovirt.org/7063 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8b8f992efa10b6846012a1a8295ee7833d485762 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: remove network backups at the end of _syncLibvirtNetworks ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/278/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7063 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8b8f992efa10b6846012a1a8295ee7833d485762 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: remove network backups at the end of _syncLibvirtNetworks ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm/clientIF.py Line 205: # Remove all backups that were created during this sync operation I find this comment redundant - the name of the function is good enough.
-- To view, visit http://gerrit.ovirt.org/7063 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8b8f992efa10b6846012a1a8295ee7833d485762 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: avoid network backups during _syncLibvirtNetworks ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/414/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7063 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8b8f992efa10b6846012a1a8295ee7833d485762 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: avoid network backups during _syncLibvirtNetworks ......................................................................
Patch Set 2: Looks good to me, approved
as much as I dislike this hack, it solves a recent regression of attempting to chown as vdsm user, and I do not have a better idea.
-- To view, visit http://gerrit.ovirt.org/7063 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8b8f992efa10b6846012a1a8295ee7833d485762 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Zhou Zheng Sheng has posted comments on this change.
Change subject: clientIF: avoid network backups during _syncLibvirtNetworks ......................................................................
Patch Set 2:
I am not sure with if we should backup or not. Why we need the backup before? Why we do not backup those config now? Why chown to vdsm:root not vdsm:kvm?
The backup behavior when removing libvirt network is introduced in commit 86a10b468be, the related RHBZ is #832765. After reading the code, I still confused with the questions above.
-- To view, visit http://gerrit.ovirt.org/7063 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8b8f992efa10b6846012a1a8295ee7833d485762 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: avoid network backups during _syncLibvirtNetworks ......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/453/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7063 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8b8f992efa10b6846012a1a8295ee7833d485762 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: avoid network backups during _syncLibvirtNetworks ......................................................................
Patch Set 4: Looks good to me, approved
still ugly, still accepted.
Zhou, your patch makes sense on its own right. I hate the chowning, but better chgrp while at it. just use the proper constatnts.
-- To view, visit http://gerrit.ovirt.org/7063 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8b8f992efa10b6846012a1a8295ee7833d485762 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: avoid network backups during _syncLibvirtNetworks ......................................................................
Patch Set 4: Verified
copying Meni's verification into here.
-- To view, visit http://gerrit.ovirt.org/7063 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8b8f992efa10b6846012a1a8295ee7833d485762 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: clientIF: avoid network backups during _syncLibvirtNetworks ......................................................................
clientIF: avoid network backups during _syncLibvirtNetworks
The target of _syncLibvirtNetworks is synchronize between host networks and libvirt's view of it. So, there is no reason for backups at this point.
Change-Id: I8b8f992efa10b6846012a1a8295ee7833d485762 Signed-off-by: Igor Lvovsky ilvovsky@redhat.com --- M vdsm/clientIF.py M vdsm/configNetwork.py 2 files changed, 10 insertions(+), 6 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7063 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I8b8f992efa10b6846012a1a8295ee7833d485762 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org