Adam Litke has uploaded a new change for review.
Change subject: rest-api: Model StorageDomains ......................................................................
rest-api: Model StorageDomains
API Implemented: ---------------- /api/storagedomains : Manipulate Storage Domains * Provide comprehensive information about known domains Actions: /api/storagedomains/create - Create a new storage domain /api/storagedomains/<id>/format - Remove and erase a storage domain /api/storagedomains/<id>/attach - Attach a storage domain to a storage pool /api/storagedomains/<id>/detach - Detach a storage domain from a storage pool /api/storagedomains/<id>/activate - Activate an inactive, attached storage domain /api/storagedomains/<id>/deactivate - Deactivate an active storage domain
Change-Id: I85060179416dc7c4a1a33ef6f8262ce31e908c26 Signed-off-by: Adam Litke agl@us.ibm.com --- M vdsm/rest/Controller.py M vdsm/rest/templates/Makefile.am M vdsm/rest/templates/api.xsd M vdsm/rest/templates/root.json.x M vdsm/rest/templates/root.xml.x M vdsm/rest/templates/rsdl.xml A vdsm/rest/templates/storagedomain.json.x A vdsm/rest/templates/storagedomain.xml.x A vdsm/rest/templates/storagedomains.json.x A vdsm/rest/templates/storagedomains.xml.x 10 files changed, 441 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/3751/1 -- To view, visit http://gerrit.ovirt.org/3751 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I85060179416dc7c4a1a33ef6f8262ce31e908c26 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com
Saggi Mizrahi has posted comments on this change.
Change subject: rest-api: Model StorageDomains ......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/rest/Controller.py Line 417: return StorageDomains(self.ctx) Looks like you'll need a dict here self._linkHandlers = {link: callback, ...} return self._linkHandlers.get(link, errorHandler)
I'd even put the dict as a class field
-- To view, visit http://gerrit.ovirt.org/3751 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I85060179416dc7c4a1a33ef6f8262ce31e908c26 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Adam Litke has posted comments on this change.
Change subject: rest-api: Model StorageDomains ......................................................................
Patch Set 8: Verified
-- To view, visit http://gerrit.ovirt.org/3751 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I85060179416dc7c4a1a33ef6f8262ce31e908c26 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: rest-api: Model StorageDomains ......................................................................
Patch Set 8: Looks good to me, approved
This has waited for a serious review for way too long. I am taking this series under the assumption that if serious changes to the REST API are still acceptable.
-- To view, visit http://gerrit.ovirt.org/3751 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I85060179416dc7c4a1a33ef6f8262ce31e908c26 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: rest-api: Model StorageDomains ......................................................................
rest-api: Model StorageDomains
API Implemented: ---------------- /api/storagedomains : Manipulate Storage Domains * Provide comprehensive information about known domains Actions: /api/storagedomains/create - Create a new storage domain /api/storagedomains/<id>/format - Remove and erase a storage domain /api/storagedomains/<id>/attach - Attach a storage domain to a storage pool /api/storagedomains/<id>/detach - Detach a storage domain from a storage pool /api/storagedomains/<id>/activate - Activate an inactive, attached storage domain /api/storagedomains/<id>/deactivate - Deactivate an active storage domain
Change-Id: I85060179416dc7c4a1a33ef6f8262ce31e908c26 Signed-off-by: Adam Litke agl@us.ibm.com --- M vdsm/rest/Controller.py M vdsm/rest/templates/Makefile.am M vdsm/rest/templates/api.xsd M vdsm/rest/templates/root.json.x M vdsm/rest/templates/root.xml.x M vdsm/rest/templates/rsdl.xml A vdsm/rest/templates/storagedomain.json.x A vdsm/rest/templates/storagedomain.xml.x A vdsm/rest/templates/storagedomains.json.x A vdsm/rest/templates/storagedomains.xml.x 10 files changed, 457 insertions(+), 0 deletions(-)
Approvals: Adam Litke: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3751 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I85060179416dc7c4a1a33ef6f8262ce31e908c26 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org