Saggi Mizrahi has uploaded a new change for review.
Change subject: Remove infile and outfile from execCmd, no one uses them ......................................................................
Remove infile and outfile from execCmd, no one uses them
All respectable tools that have a reason to write to disk have this option built in. This is why we never used or tested this feature.
Change-Id: Ia4258ca2c7653462d6da046fb895de9d61a38212 Signed-off-by: Saggi Mizrahi smizrahi@redhat.com --- M tests/miscTests.py M vdsm/storage/misc.py 2 files changed, 12 insertions(+), 34 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/3942/1 -- To view, visit http://gerrit.ovirt.org/3942 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ia4258ca2c7653462d6da046fb895de9d61a38212 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Remove infile and outfile from execCmd, no one uses them ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3942 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia4258ca2c7653462d6da046fb895de9d61a38212 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Remove infile and outfile from execCmd, no one uses them ......................................................................
Patch Set 6: Verified; Looks good to me, approved
I don't wanna see this patch again
-- To view, visit http://gerrit.ovirt.org/3942 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia4258ca2c7653462d6da046fb895de9d61a38212 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove infile and outfile from execCmd, no one uses them ......................................................................
Remove infile and outfile from execCmd, no one uses them
All respectable tools that have a reason to write to disk have this option built in. This is why we never used or tested this feature.
Change-Id: Ia4258ca2c7653462d6da046fb895de9d61a38212 Signed-off-by: Saggi Mizrahi smizrahi@redhat.com --- M tests/miscTests.py M vdsm/storage/misc.py 2 files changed, 12 insertions(+), 34 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3942 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ia4258ca2c7653462d6da046fb895de9d61a38212 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org