Dan Kenigsberg has uploaded a new change for review.
Change subject: BZ#772556 bootstrap: ignore restorecon errors ......................................................................
BZ#772556 bootstrap: ignore restorecon errors
This is particularly painful if SELinux is disabled.
Change-Id: I0af8e5f68c2d1ec52208684b95bcff2e68ba88fe --- M vds_bootstrap/vds_bootstrap.py M vdsm_reg/deployUtil.py.in 2 files changed, 11 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/1022/1 -- To view, visit http://gerrit.ovirt.org/1022 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I0af8e5f68c2d1ec52208684b95bcff2e68ba88fe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: BZ#772556 bootstrap: ignore restorecon errors ......................................................................
Patch Set 1: Looks good to me, approved
I didn't test it but it looks good.
-- To view, visit http://gerrit.ovirt.org/1022 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0af8e5f68c2d1ec52208684b95bcff2e68ba88fe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#772556 bootstrap: ignore restorecon errors ......................................................................
Patch Set 1: Verified
not really verified, I'm afraid
-- To view, visit http://gerrit.ovirt.org/1022 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0af8e5f68c2d1ec52208684b95bcff2e68ba88fe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#772556 bootstrap: ignore restorecon errors ......................................................................
Patch Set 2: Verified; Looks good to me, approved
rebased
-- To view, visit http://gerrit.ovirt.org/1022 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0af8e5f68c2d1ec52208684b95bcff2e68ba88fe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#772556 bootstrap: ignore restorecon errors ......................................................................
BZ#772556 bootstrap: ignore restorecon errors
This is particularly painful if SELinux is disabled.
Change-Id: I0af8e5f68c2d1ec52208684b95bcff2e68ba88fe --- M vds_bootstrap/vds_bootstrap.py M vdsm_reg/deployUtil.py.in 2 files changed, 11 insertions(+), 6 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1022 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I0af8e5f68c2d1ec52208684b95bcff2e68ba88fe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Haim Ateya has posted comments on this change.
Change subject: BZ#772556 bootstrap: ignore restorecon errors ......................................................................
Patch Set 2:
verified. disabled selinux on one of my machines, rebooted, installed reinstalled vdsm, had a nice exception for SELINUX restorecon failure, and installation finished successfully.
-- To view, visit http://gerrit.ovirt.org/1022 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0af8e5f68c2d1ec52208684b95bcff2e68ba88fe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
vdsm-patches@lists.fedorahosted.org