From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: vm: create a vnic with vhostuser backend ......................................................................
Patch Set 33:
(1 comment)
https://gerrit.ovirt.org/#/c/74327/33/vdsm/virt/vm.py File vdsm/virt/vm.py:
Line 2250: if self.recovering: Line 2251: self._dom = virdomain.Notifying( Line 2252: self._connection.lookupByUUIDString(self.id), Line 2253: self._timeoutExperienced) Line 2254: for dev in self._devices[hwclass.NIC]:
yes, recover() is implemented only in network devices and I had to call it
the effects of this change are more far-reaching than dpdk. *I* feel comfortable with keeping it here. Francesco may want a separate first patch with that introduces the Device.recover() method and explains why its needed. Line 2255: dev.recover() Line 2256: elif self._altered_state.origin == _MIGRATION_ORIGIN: Line 2257: pass # self._dom will be disconnected until migration ends. Line 2258: elif self._altered_state.origin == _FILE_ORIGIN:
vdsm-patches@lists.fedorahosted.org