Nir Soffer has uploaded a new change for review.
Change subject: procwatch: Move test helpers to bottom ......................................................................
procwatch: Move test helpers to bottom
The most important thing in a test class are the tests, not the helpers. If you want to inspect the implementation details please scroll down.
Change-Id: Ib5909a0016b04d67cbdeec845234bcfcb61fbde7 Signed-off-by: Nir Soffer nsoffer@redhat.com --- M tests/procwatch_test.py 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/65075/1
diff --git a/tests/procwatch_test.py b/tests/procwatch_test.py index 1c6b365..49181f5 100644 --- a/tests/procwatch_test.py +++ b/tests/procwatch_test.py @@ -32,12 +32,6 @@ @expandPermutations class ProcessWatcherTests(VdsmTestCase):
- def assertUnexpectedCall(self, data): - raise AssertionError("Unexpected data: %r" % data) - - def startCommand(self, command): - return compat.CPopen(command) - @permutations([ (['echo', '-n', '%s'], True, False), (['sh', '-c', 'echo -n "%s" >&2'], False, True), @@ -130,3 +124,9 @@ retcode = c.wait()
self.assertEqual(retcode, expected_retcode) + + def assertUnexpectedCall(self, data): + raise AssertionError("Unexpected data: %r" % data) + + def startCommand(self, command): + return compat.CPopen(command)
gerrit-hooks has posted comments on this change.
Change subject: procwatch: Move test helpers to bottom ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: procwatch: Move test helpers to bottom ......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: procwatch: Move test helpers to bottom ......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: procwatch: Move test helpers to bottom ......................................................................
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: procwatch: Move test helpers to bottom ......................................................................
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
vdsm-patches@lists.fedorahosted.org