ShaoHe Feng has uploaded a new change for review.
Change subject: Clean the RHEVM log message in vdsm_reg/deployUtil.py.in ......................................................................
Clean the RHEVM log message in vdsm_reg/deployUtil.py.in
Change-Id: I5d4f4604fab5d17120ab19341f4a64b4820c5636 Signed-off-by: ShaoHe Feng shaohef@linux.vnet.ibm.com --- M vdsm_reg/deployUtil.py.in 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/3801/1 -- To view, visit http://gerrit.ovirt.org/3801 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I5d4f4604fab5d17120ab19341f4a64b4820c5636 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com
Bruce Bai has posted comments on this change.
Change subject: Clean the RHEVM log message in vdsm_reg/deployUtil.py.in ......................................................................
Patch Set 1:
if this modification use the macro definition will be much better than translate every separately words.maybe should refer to the "Change Ibb9876fb: BZ#813423: Adding ENGINENAME macro"
-- To view, visit http://gerrit.ovirt.org/3801 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5d4f4604fab5d17120ab19341f4a64b4820c5636 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Bruce Bai baichm@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Clean the RHEVM log message in deployUtil.py.in ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3801 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5d4f4604fab5d17120ab19341f4a64b4820c5636 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Bruce Bai baichm@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com
ShaoHe Feng has posted comments on this change.
Change subject: Clean the RHEVM log message in deployUtil.py.in ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/3801 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5d4f4604fab5d17120ab19341f4a64b4820c5636 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Bruce Bai baichm@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Clean the RHEVM log message in deployUtil.py.in ......................................................................
Clean the RHEVM log message in deployUtil.py.in
Change-Id: I5d4f4604fab5d17120ab19341f4a64b4820c5636 Signed-off-by: ShaoHe Feng shaohef@linux.vnet.ibm.com --- M vdsm_reg/deployUtil.py.in 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: ShaoHe Feng: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3801 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I5d4f4604fab5d17120ab19341f4a64b4820c5636 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Bruce Bai baichm@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org