ShaoHe Feng has uploaded a new change for review.
Change subject: change the code style of before_vm_start.py for PEP8 compliance ......................................................................
change the code style of before_vm_start.py for PEP8 compliance
Change-Id: I15551c9a756b3c1e3f1ef6558623c1008a5b8f47 Signed-off-by: ShaoHe Feng shaohef@linux.vnet.ibm.com --- M Makefile.am M vdsm_hooks/sriov/before_vm_start.py 2 files changed, 28 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/4552/1 -- To view, visit http://gerrit.ovirt.org/4552 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I15551c9a756b3c1e3f1ef6558623c1008a5b8f47 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: change the code style of before_vm_start.py for PEP8 compliance ......................................................................
Patch Set 1: (2 inline comments)
.................................................... File vdsm_hooks/sriov/before_vm_start.py Line 39: firstChild.nodeValue)) How about
slot = hex(int( devXml.getElementsByTagName('slot')[0] .firstChild.nodeValue))
Line 41: firstChild.nodeValue)) How about
function = hex(int( devXml.getElementsByTagName('function')[0] .firstChild.nodeValue))
-- To view, visit http://gerrit.ovirt.org/4552 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I15551c9a756b3c1e3f1ef6558623c1008a5b8f47 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Saggi Mizrahi has posted comments on this change.
Change subject: change the code style of before_vm_start.py for PEP8 compliance ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4552 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I15551c9a756b3c1e3f1ef6558623c1008a5b8f47 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: change the code style of before_vm_start.py for PEP8 compliance ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4552 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I15551c9a756b3c1e3f1ef6558623c1008a5b8f47 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
ShaoHe Feng has abandoned this change.
Change subject: change the code style of before_vm_start.py for PEP8 compliance ......................................................................
Patch Set 2: Abandoned
it was merged in pep8cleaning branch.
-- To view, visit http://gerrit.ovirt.org/4552 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I15551c9a756b3c1e3f1ef6558623c1008a5b8f47 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org