Royce Lv has uploaded a new change for review.
Change subject: check disk shared flag exist before use it ......................................................................
check disk shared flag exist before use it
The cdrom shared flag is just added by current engine(e548c72ee1d92) but not included in release 3.1, making test latest vdsm vm create always fail.This patch makes vdsm compatible with the earlier engine version.
Change-Id: Ib0d9378de9ea8affd2f5d071839ee18b53a8b2ef Signed-off-by: Royce Lvlvroyce@linux.vnet.ibm.com --- M vdsm/libvirtvm.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/7051/1 -- To view, visit http://gerrit.ovirt.org/7051 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ib0d9378de9ea8affd2f5d071839ee18b53a8b2ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: check disk shared flag exist before use it ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/273/
-- To view, visit http://gerrit.ovirt.org/7051 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib0d9378de9ea8affd2f5d071839ee18b53a8b2ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: check disk shared flag exist before use it ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/273/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7051 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib0d9378de9ea8affd2f5d071839ee18b53a8b2ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: check disk shared flag exist before use it ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
we must honour some kind of backward compatibility - certainly downstream.
-- To view, visit http://gerrit.ovirt.org/7051 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib0d9378de9ea8affd2f5d071839ee18b53a8b2ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Royce Lv has posted comments on this change.
Change subject: check disk shared flag exist before use it ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/7051 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib0d9378de9ea8affd2f5d071839ee18b53a8b2ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: check disk shared flag exist before use it ......................................................................
Patch Set 1: Looks good to me, approved
Unfortunately, we cannot re-spin ovirt-3.1 so that Engine avoids its buggy behavior.
I know that there are Vdsm developers that would not like Vdsm to "cave in". I am afraid that without them stating their opinion here, I cannot take their sentiments too deeply.
Thanks, Royce.
-- To view, visit http://gerrit.ovirt.org/7051 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib0d9378de9ea8affd2f5d071839ee18b53a8b2ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: check disk shared flag exist before use it ......................................................................
check disk shared flag exist before use it
The cdrom shared flag is just added by current engine(e548c72ee1d92) but not included in release 3.1, making test latest vdsm vm create always fail.This patch makes vdsm compatible with the earlier engine version.
Change-Id: Ib0d9378de9ea8affd2f5d071839ee18b53a8b2ef Signed-off-by: Royce Lvlvroyce@linux.vnet.ibm.com --- M vdsm/libvirtvm.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Royce Lv: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7051 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ib0d9378de9ea8affd2f5d071839ee18b53a8b2ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org