Milan Zamazal has uploaded a new change for review.
Change subject: virt: Minor typo fixes in Vm.getStats docstring ......................................................................
virt: Minor typo fixes in Vm.getStats docstring
Change-Id: I4e07c9b237cf0af22ec8d0f7618ab655839839f2 Signed-off-by: Milan Zamazal mzamazal@redhat.com --- M vdsm/virt/vm.py 1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/63550/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index c936987..2526051 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -1180,13 +1180,12 @@
def getStats(self): """ - used by API.Vm.getStats + Used by API.Vm.getStats.
- WARNING: this method should only gather statistics by copying data. - Especially avoid costly and dangerous ditrect calls to the _dom + WARNING: This method should only gather statistics by copying data. + Especially avoid costly and dangerous direct calls to the _dom attribute. Use the periodic operations instead! """ - stats = {'statusTime': self._get_status_time()} if self.lastStatus == vmstatus.DOWN: stats.update(self._getDownVmStats())
gerrit-hooks has posted comments on this change.
Change subject: virt: Minor typo fixes in Vm.getStats docstring ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: virt: Minor typo fixes in Vm.getStats docstring ......................................................................
Patch Set 2:
* update_tracker: OK * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Francesco Romani has posted comments on this change.
Change subject: virt: Minor typo fixes in Vm.getStats docstring ......................................................................
Patch Set 2: Code-Review+2
gerrit-hooks has posted comments on this change.
Change subject: virt: Minor typo fixes in Vm.getStats docstring ......................................................................
Patch Set 3:
* update_tracker: OK * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Milan Zamazal has posted comments on this change.
Change subject: virt: Minor typo fixes in Vm.getStats docstring ......................................................................
Patch Set 3: Verified+1
Just a documentation change, I checked build works. Jenkins test failures on Fedora are unrelated.
Nir Soffer has posted comments on this change.
Change subject: virt: Minor typo fixes in Vm.getStats docstring ......................................................................
Patch Set 3: Code-Review+1
gerrit-hooks has posted comments on this change.
Change subject: virt: Minor typo fixes in Vm.getStats docstring ......................................................................
Patch Set 4:
* Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Minor typo fixes in Vm.getStats docstring ......................................................................
virt: Minor typo fixes in Vm.getStats docstring
Change-Id: I4e07c9b237cf0af22ec8d0f7618ab655839839f2 Signed-off-by: Milan Zamazal mzamazal@redhat.com Reviewed-on: https://gerrit.ovirt.org/63550 Reviewed-by: Francesco Romani fromani@redhat.com Reviewed-by: Nir Soffer nsoffer@redhat.com Continuous-Integration: Jenkins CI --- M vdsm/virt/vm.py 1 file changed, 3 insertions(+), 4 deletions(-)
Approvals: Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Milan Zamazal: Verified
gerrit-hooks has posted comments on this change.
Change subject: virt: Minor typo fixes in Vm.getStats docstring ......................................................................
Patch Set 5:
* Update Tracker::IGNORE, no bug url/s found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org