ShaoHe Feng has uploaded a new change for review.
Change subject: change the code style of before_vm_start.py for PEP8 compliance ......................................................................
change the code style of before_vm_start.py for PEP8 compliance
Change-Id: Ie2c1602db5457ee1751869a604ece1a957aeb865 Signed-off-by: ShaoHe Feng shaohef@linux.vnet.ibm.com --- M Makefile.am M vdsm_hooks/fileinject/before_vm_start.py 2 files changed, 41 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/4549/1 -- To view, visit http://gerrit.ovirt.org/4549 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ie2c1602db5457ee1751869a604ece1a957aeb865 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: change the code style of before_vm_start.py for PEP8 compliance ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4549 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie2c1602db5457ee1751869a604ece1a957aeb865 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
ShaoHe Feng has abandoned this change.
Change subject: change the code style of before_vm_start.py for PEP8 compliance ......................................................................
Patch Set 1: Abandoned
it was merged in pep8cleaning branch.
-- To view, visit http://gerrit.ovirt.org/4549 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: Ie2c1602db5457ee1751869a604ece1a957aeb865 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org