Zhou Zheng Sheng has uploaded a new change for review.
Change subject: rename xml.dom.minidom.parseString to _domParseStr in libvirtvm ......................................................................
rename xml.dom.minidom.parseString to _domParseStr in libvirtvm
The old name is too long and is copied everywhere. Using a shorter name helps shorten the line length.
Change-Id: I2e4ed0795b887c3df292eee1e2555428e1e9beae Signed-off-by: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com --- M vdsm/libvirtvm.py 1 file changed, 30 insertions(+), 29 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/6847/1 -- To view, visit http://gerrit.ovirt.org/6847 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I2e4ed0795b887c3df292eee1e2555428e1e9beae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: rename xml.dom.minidom.parseString to _domParseStr in libvirtvm ......................................................................
Patch Set 1: Verified; Looks good to me, but someone else must approve
(1 inline comment)
Run through autobuild.sh, but I disable two tests, testAddNetworkValidation and test_mkFloppyFs. These two tests will fail on my machine when I checkout the latest master and build.
Examine all the changes using pydiff. pydiff says all the changes is about the short name. So we can know no other things are changed.
The detailed pydiff report:
pydiff libvirtvmo.py libvirtvm.py 12 difference(s) first file: libvirtvmo.py second file: libvirtvm.py
((24, None), (24, From('xml.dom.minidom', [('parseString', '_domParseStr')], 0)))
((1928, "Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"), (1929, "Name('_domParseStr')"))
((1944, "Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"), (1945, "Name('_domParseStr')"))
((2000, "Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"), (2001, "Name('_domParseStr')"))
((2132, "Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"), (2133, "Name('_domParseStr')"))
((2157, "Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"), (2158, "Name('_domParseStr')"))
((2204, "Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"), (2205, "Name('_domParseStr')"))
((2229, "Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"), (2230, "Name('_domParseStr')"))
((2258, "Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"), (2259, "Name('_domParseStr')"))
((2287, "Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"), (2288, "Name('_domParseStr')"))
((2352, "Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"), (2353, "Name('_domParseStr')"))
((2366, "Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"), (2367, "Name('_domParseStr')"))
.................................................... File vdsm/libvirtvm.py Line 2290: getElementsByTagName('disk') The .getElementsByTagName() call chain can be rewritten using XPath. Regarding we have to write many test cases to verify a XPath patch code logic is the same as current code, we can just live with the current version.
-- To view, visit http://gerrit.ovirt.org/6847 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2e4ed0795b887c3df292eee1e2555428e1e9beae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: rename xml.dom.minidom.parseString to _domParseStr in libvirtvm ......................................................................
Patch Set 1: No score
-- To view, visit http://gerrit.ovirt.org/6847 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2e4ed0795b887c3df292eee1e2555428e1e9beae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: rename xml.dom.minidom.parseString to _domParseStr in libvirtvm ......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 2290: getElementsByTagName('disk') thanks. there's always time for another, smarter patch.
-- To view, visit http://gerrit.ovirt.org/6847 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2e4ed0795b887c3df292eee1e2555428e1e9beae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Gal Hammer has posted comments on this change.
Change subject: rename xml.dom.minidom.parseString to _domParseStr in libvirtvm ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6847 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2e4ed0795b887c3df292eee1e2555428e1e9beae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: rename xml.dom.minidom.parseString to _domParseStr in libvirtvm ......................................................................
rename xml.dom.minidom.parseString to _domParseStr in libvirtvm
The old name is too long and is copied everywhere. Using a shorter name helps shorten the line length.
Change-Id: I2e4ed0795b887c3df292eee1e2555428e1e9beae Signed-off-by: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com --- M vdsm/libvirtvm.py 1 file changed, 30 insertions(+), 29 deletions(-)
Approvals: Gal Hammer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Zhou Zheng Sheng: Verified
-- To view, visit http://gerrit.ovirt.org/6847 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I2e4ed0795b887c3df292eee1e2555428e1e9beae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org