Petr Horáček has uploaded a new change for review.
Change subject: net tests: bond tests fails on CI with ctypes.AttributeError ......................................................................
net tests: bond tests fails on CI with ctypes.AttributeError
Change-Id: I6c88dd66056cbb1f65f77e8b1a7cf1f03e4fb80a --- M tests/network/link_bond_test.py 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/64345/1
diff --git a/tests/network/link_bond_test.py b/tests/network/link_bond_test.py index a610f63..7eb8b00 100644 --- a/tests/network/link_bond_test.py +++ b/tests/network/link_bond_test.py @@ -20,12 +20,15 @@
from contextlib import contextmanager
+import ctypes + from nose.plugins.attrib import attr from nose.plugins.skip import SkipTest
from testlib import VdsmTestCase as TestCaseBase
from .nettestlib import dummy_devices +from testValidation import broken_on_ci
from vdsm.network.link import iface from vdsm.network.link.bond import Bond @@ -41,16 +44,19 @@ @attr(type='integration') class LinkBondTests(TestCaseBase):
+ @broken_on_ci(exception=ctypes.ArgumentError) def test_bond_without_slaves(self): with bond_device() as bond: self.assertFalse(iface.is_up(bond.master))
+ @broken_on_ci(exception=ctypes.ArgumentError) def test_bond_with_slaves(self): with dummy_devices(2) as (nic1, nic2): with bond_device() as bond: bond.add_slaves((nic1, nic2)) self.assertFalse(iface.is_up(bond.master))
+ @broken_on_ci(exception=ctypes.ArgumentError) def test_bond_devices_are_up(self): with dummy_devices(2) as (nic1, nic2): with bond_device() as bond: @@ -60,6 +66,7 @@ self.assertTrue(iface.is_up(nic2)) self.assertTrue(iface.is_up(bond.master))
+ @broken_on_ci(exception=ctypes.ArgumentError) def test_bond_exists(self): with dummy_devices(2) as (nic1, nic2): with bond_device() as _bond: @@ -77,6 +84,7 @@ expected_bond_set = set([b1.master, b2.master, b3.master]) self.assertLessEqual(expected_bond_set, actual_bond_set)
+ @broken_on_ci(exception=ctypes.ArgumentError) def test_bond_create_failure_on_slave_add(self): with dummy_devices(2) as (nic1, nic2): with bond_device() as base_bond: @@ -89,6 +97,7 @@ broken_bond.add_slaves((nic1, nic2)) self.assertFalse(Bond(bond_name).exists())
+ @broken_on_ci(exception=ctypes.ArgumentError) def test_bond_edit_failure_on_slave_add(self): with dummy_devices(2) as (nic1, nic2): with bond_device() as base_bond, bond_device() as edit_bond:
gerrit-hooks has posted comments on this change.
Change subject: net tests: bond tests fails on CI with ctypes.AttributeError ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: bond tests fails on CI with ctypes.AttributeError ......................................................................
Patch Set 1:
The commit message needs some beefing: admit that we have no idea what are these failures.
does all the tests here are susceptible to this error?
gerrit-hooks has posted comments on this change.
Change subject: net tests: bond tests fails on CI with ctypes.AttributeError ......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: net tests: blacklist link_bond_test ......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: blacklist link_bond_test ......................................................................
Patch Set 3:
but https://gerrit.ovirt.org/64060 passed with no problem; and link_bond_test passes on my laptop. Can you use this repeated failure to pinpoint the true reason of the ctype error? I find the @broken_on_ci "fix" better.
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: blacklist link_bond_test ......................................................................
Patch Set 3: Code-Review-1
gerrit-hooks has posted comments on this change.
Change subject: net tests: bond tests fails on CI with ctypes.AttributeError ......................................................................
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: bond tests fails on CI with ctypes.AttributeError ......................................................................
Patch Set 4: Code-Review+2 Verified+1
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: bond tests fails on CI with ctypes.AttributeError ......................................................................
Patch Set 4: Continuous-Integration+1
Unrelated failure in
====================================================================== ERROR: test_reject_concurrency(False) (protocoldetectorTests.AcceptorTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests/protocoldetectorTests.py", line 113, in tearDown self.acceptor.stop() File "/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/lib/vdsm/protocoldetector.py", line 211, in stop self._acceptor.close() File "/usr/lib64/python2.7/asyncore.py", line 407, in close self.del_channel() File "/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/lib/yajsonrpc/betterAsyncore.py", line 137, in del_channel asyncore.dispatcher.del_channel(self, map) File "/usr/lib64/python2.7/asyncore.py", line 292, in del_channel del map[fd] KeyError: 63
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: bond tests fails on CI with ctypes.AttributeError ......................................................................
net tests: bond tests fails on CI with ctypes.AttributeError
Quite often the marked tests fail on CI (when they do, all of them fail), at the moment we have no clue why they fail (most often on Python 3). For now we should at least silence them.
Change-Id: I6c88dd66056cbb1f65f77e8b1a7cf1f03e4fb80a Reviewed-on: https://gerrit.ovirt.org/64345 Reviewed-by: Dan Kenigsberg danken@redhat.com Tested-by: Dan Kenigsberg danken@redhat.com Continuous-Integration: Dan Kenigsberg danken@redhat.com --- M tests/network/link_bond_test.py 1 file changed, 9 insertions(+), 0 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved; Passed CI tests
Objections: Jenkins CI: Failed CI tests
gerrit-hooks has posted comments on this change.
Change subject: net tests: bond tests fails on CI with ctypes.AttributeError ......................................................................
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org