Amador Pahim has uploaded a new change for review.
Change subject: BZ#846604 Check if NTPd is up before clock sync. ......................................................................
BZ#846604 Check if NTPd is up before clock sync.
During boostrap, host clock is syncronized with engine time. If ntpd is running on host, time in host will jump to engine time and jump back to ntp time few moments later (when engine time is not in sync with ntp time). This patch checks if ntpd is running in order to skip clock sync, if yes.
Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Signed-off-by: Amador Pahim apahim@redhat.com --- M configure.ac M vdsm_reg/deployUtil.py.in 2 files changed, 22 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/7070/1 -- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#846604 Check if NTPd is up before clock sync. ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/294/
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#846604 Check if NTPd is up before clock sync. ......................................................................
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/294/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#846604 Check if NTPd is up before clock sync. ......................................................................
Patch Set 1: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/295/
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#846604 Check if NTPd is up before clock sync. ......................................................................
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/295/ : ABORTED
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#846604 Check if NTPd is up before clock sync. ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/306/
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#846604 Check if NTPd is up before clock sync. ......................................................................
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/306/ : ABORTED
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#846604 Check if NTPd is up before clock sync. ......................................................................
Patch Set 2: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/307/
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#846604 Check if NTPd is up before clock sync. ......................................................................
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/307/ : ABORTED
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Amador Pahim has posted comments on this change.
Change subject: BZ#846604 Check if NTPd is up before clock sync. ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#846604 Check if NTPd is up before clock sync. ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
I don't see a reason why jenkins aborted the task.. but there is nothing related with the patch.
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#846604 Skip clock sync if NTPd is running. ......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/342/
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#846604 Skip clock sync if NTPd is running. ......................................................................
Patch Set 3: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/342/ : ABORTED
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#846604 Skip clock sync if NTPd is running. ......................................................................
Patch Set 3: I would prefer that you didn't submit this
A more reasonable indication that clock sync is not needed is to check `ntpstat".
However, I think that the most important issue is to require ntpd in Engine, too.
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Amador Pahim has posted comments on this change.
Change subject: BZ#846604 Skip clock sync if NTPd is running. ......................................................................
Patch Set 3:
Indeed. Changing to ntpstat. Now I'm working to check ntpd during engine-setup.
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Amador Pahim has posted comments on this change.
Change subject: BZ#846604 Skip clock sync if NTPd is running. ......................................................................
Patch Set 4: Verified
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#846604 Skip clock sync if NTPd is running. ......................................................................
Patch Set 4: Looks good to me, but someone else must approve
Indeed, looks better with ntpstat.
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: BZ#846604 Skip clock sync if NTPd is running. ......................................................................
Patch Set 4:
Yes, I noticed this problem too, was in my list.
I don't like to use rhel specific utilities if we are not force to, ntptime is part of ntp package, I think it has more potential to ease our porting in future.
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: BZ#846604 Skip clock sync if NTPd is running. ......................................................................
Patch Set 4:
or ntpq -p or any other command which does not require any more dependencies...
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Itamar Heim has posted comments on this change.
Change subject: BZ#846604 Skip clock sync if NTPd is running. ......................................................................
Patch Set 4: (1 inline comment)
.................................................... File vdsm_reg/deployUtil.py.in Line 674: if fReturn: Line 675: out, err, rc = _logExec([EX_HWCLOCK, "--set", "--utc", Line 676: time.strftime('--date=%Y-%m-%d %H:%M:%S UTC', ttp)]) Line 677: if rc: Line 678: logging.debug("setHostTime: Failed to set hwclock time. out=" + out + "\nerr=" + str(err) + "\nrc=" + str(rc)) dummy comment - please ignore Line 679: fReturn = False Line 680: Line 681: if fReturn: Line 682: out, err, rc = _logExec([EX_HWCLOCK, "-s"])
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Amador Pahim has posted comments on this change.
Change subject: BZ#846604 Skip clock sync if NTPd is running. ......................................................................
Patch Set 4:
Alon, what do you think about this? ... out, err, rc = _logExec(['ntpq', "-c", "rv"]) if 'clock_sync' in out: ...
Dan? Dougsland?
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#846604 Skip clock sync if NTPd is running. ......................................................................
Patch Set 4: No score
Alon, what do you think about this? ... out, err, rc = _logExec(['ntpq', "-c", "rv"]) if 'clock_sync' in out: ... Dan? Dougsland?
From my side, looks good.
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: BZ#846604 Skip clock sync if NTPd is running. ......................................................................
Patch Set 4:
Hi,
It tells you that ntpd is up but not if clock is synced.
ntptime completes this information...
Maybe there is a better solution, however what we need to know is that host is synchronized, the fact that ntp is running is a bonus.
Thanks!
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Amador Pahim has posted comments on this change.
Change subject: BZ#846604 Skip clock sync if NTPd is running. ......................................................................
Patch Set 4:
Hmm, actually the 'ntpq -c rv' will not return "clock_sync" when not synchronized:
sync: associd=0 status=0615 leap_none, sync_ntp, 1 event, clock_sync,
not sync: associd=0 status=c012 leap_alarm, sync_unspec, 1 event, freq_set,
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: BZ#846604 Skip clock sync if NTPd is running. ......................................................................
Patch Set 4:
Right. Sorry, my ntp configuration was a mess. Now tested this and you are right.
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: BZ#846604 Skip clock sync if NTPd is running. ......................................................................
Patch Set 4: (1 inline comment)
.................................................... Commit Message Line 3: AuthorDate: 2012-08-09 15:34:30 -0300 Line 4: Commit: Amador Pahim apahim@redhat.com Line 5: CommitDate: 2012-08-10 13:49:22 -0300 Line 6: Line 7: BZ#846604 Skip clock sync if NTPd is running. Please modify to something like:
BZ#846604 bootstrap: skip clock sync if ntpd is synced Line 8: Line 9: During boostrap, host clock is syncronized with Line 10: engine time. If ntpd is running on host and engine Line 11: time is not synchronized with ntp server, time in
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#846604 Skip clock sync if NTPd is running. ......................................................................
Patch Set 4: I would prefer that you didn't submit this
-1 since Amador will send a new version.
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Amador Pahim has posted comments on this change.
Change subject: BZ#846604 bootstrap: skip clock sync if ntpd is synced ......................................................................
Patch Set 5: Verified
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: BZ#846604 bootstrap: skip clock sync if ntpd is synced ......................................................................
Patch Set 5: (1 inline comment)
.................................................... File configure.ac Line 152: AC_PATH_PROG([MOUNT_PATH], [mount], [/bin/mount]) Line 153: AC_PATH_PROG([MULTIPATH_PATH], [multipath], [/sbin/multipath]) Line 154: AC_PATH_PROG([MV_PATH], [mv], [/bin/mv]) Line 155: AC_PATH_PROG([NICE_PATH], [nice], [/bin/nice]) Line 156: AC_PATH_PROG([NTPQ_PATH], [ntpq], [/sbin/ntpq]) This should be /usr/sbin/ntpq, at fedora /sbin->/usr/sbin confuses. Line 157: AC_PATH_PROG([OPENSSL_PATH], [openssl], [/usr/bin/openssl]) Line 158: AC_PATH_PROG([PERSIST_PATH], [persist], [/usr/sbin/persist]) Line 159: AC_PATH_PROG([PGREP_PATH], [pgrep], [/usr/bin/pgrep]) Line 160: AC_PATH_PROG([QEMUIMG_PATH], [qemu-img], [/usr/bin/qemu-img])
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Amador Pahim has posted comments on this change.
Change subject: BZ#846604 bootstrap: skip clock sync if ntpd is synced ......................................................................
Patch Set 5: (1 inline comment)
.................................................... File configure.ac Line 152: AC_PATH_PROG([MOUNT_PATH], [mount], [/bin/mount]) Line 153: AC_PATH_PROG([MULTIPATH_PATH], [multipath], [/sbin/multipath]) Line 154: AC_PATH_PROG([MV_PATH], [mv], [/bin/mv]) Line 155: AC_PATH_PROG([NICE_PATH], [nice], [/bin/nice]) Line 156: AC_PATH_PROG([NTPQ_PATH], [ntpq], [/sbin/ntpq]) Done Line 157: AC_PATH_PROG([OPENSSL_PATH], [openssl], [/usr/bin/openssl]) Line 158: AC_PATH_PROG([PERSIST_PATH], [persist], [/usr/sbin/persist]) Line 159: AC_PATH_PROG([PGREP_PATH], [pgrep], [/usr/bin/pgrep]) Line 160: AC_PATH_PROG([QEMUIMG_PATH], [qemu-img], [/usr/bin/qemu-img])
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Amador Pahim has posted comments on this change.
Change subject: BZ#846604 bootstrap: skip clock sync if ntpd is synced ......................................................................
Patch Set 6: Verified
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: BZ#846604 bootstrap: skip clock sync if ntpd is synced ......................................................................
Patch Set 6: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#846604 bootstrap: skip clock sync if ntpd is synced ......................................................................
Patch Set 6: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#846604 bootstrap: skip clock sync if ntpd is synced ......................................................................
Patch Set 6: Looks good to me, approved
Thanks, guys!
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#846604 bootstrap: skip clock sync if ntpd is synced ......................................................................
BZ#846604 bootstrap: skip clock sync if ntpd is synced
During boostrap, host clock is synchronised with engine time. If on host ntpd is synced and on engine time is not synced, time in host will jump to engine time then jump back to ntp time few moments later. This patch checks if ntpd is synced in order to skip host clock sync with engine time when true.
Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Signed-off-by: Amador Pahim apahim@redhat.com --- M configure.ac M vdsm_reg/deployUtil.py.in 2 files changed, 22 insertions(+), 16 deletions(-)
Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Douglas Schilling Landgraf: Looks good to me, but someone else must approve Amador Pahim: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7070 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ie594dfef430c811f920f304c5182be9e34f6fbf1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org