ShaoHe Feng has uploaded a new change for review.
Change subject: change the code style of resourceFactories.py for PEP8 compliance ......................................................................
change the code style of resourceFactories.py for PEP8 compliance
Change-Id: I55935f921f8466c8b359c2291eebb145245e5766 Signed-off-by: ShaoHe Feng shaohef@linux.vnet.ibm.com --- M vdsm/storage/resourceFactories.py 1 file changed, 25 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/4551/1 -- To view, visit http://gerrit.ovirt.org/4551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I55935f921f8466c8b359c2291eebb145245e5766 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: change the code style of resourceFactories.py for PEP8 compliance ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55935f921f8466c8b359c2291eebb145245e5766 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
ShaoHe Feng has abandoned this change.
Change subject: change the code style of resourceFactories.py for PEP8 compliance ......................................................................
Patch Set 2: Abandoned
it was merged in pep8cleaning branch.
-- To view, visit http://gerrit.ovirt.org/4551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I55935f921f8466c8b359c2291eebb145245e5766 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org